Skip to content

Scripts list patch - #74

Merged
sizzlemctwizzle merged 2 commits into
masterfrom
issue-55
Feb 27, 2014
Merged

sizzlemctwizzle merged 2 commits into
masterfrom
issue-55

Conversation

@sizzlemctwizzle

Copy link
Copy Markdown
Member

Put a sortable and orderable list of scripts on both the home page and profiles. The HTML/CSS is fucked up but that's not my job. Closes #55.

@sizzlemctwizzle

Copy link
Copy Markdown
Member Author

As usual, someone please test and hit the merge button.

Edit: Screw it. From now on until the site is actually working, I'm just going to merge things myself.

@sizzlemctwizzle sizzlemctwizzle added this to the 0.1 milestone Feb 27, 2014
sizzlemctwizzle added a commit that referenced this pull request Feb 27, 2014
@sizzlemctwizzle
sizzlemctwizzle merged commit 857da0f into master Feb 27, 2014
@jerone

jerone commented Feb 27, 2014

Copy link
Copy Markdown
Contributor

Did some fast testing and looks great.

Only feedback I have is http://openuserjs.org/scripts/sort/XXX is the same as http://openuserjs.org/scripts/sort/XXX/dir/asc, giving us two urls with the same content. SEO friendly blabla....

Off-topic: just merge your stuff when you have something finished; you're the only active dev and the site isn't released anyways. If someone disagrees we can start a discussion.

@sizzlemctwizzle

Copy link
Copy Markdown
Member Author

Only feedback I have is http://openuserjs.org/scripts/sort/XXX is the same as http://openuserjs.org/scripts/sort/XXX/dir/asc

That's only true if you're sorting by a text field. Numeric and date fields are sorted descending by default. There are a total of four separate parameters and they have default values (which is when they'll be hidden), but you could also use the explicit url. My goal was to keep urls as clean as possible, but still make them powerful.

Off-topic: just merge your stuff when you have something finished; you're the only active dev and the site isn't released anyways. If someone disagrees we can start a discussion.

Yeah, I figured that out today.

@jerone

jerone commented Feb 27, 2014

Copy link
Copy Markdown
Contributor

That's only true if you're sorting by a text field. Numeric and date fields are sorted descending by default. There are a total of four separate parameters and they have default values (which is when they'll be hidden), but you could also use the explicit url. My goal was to keep urls as clean as possible, but still make them powerful.

I understand that and those urls are great, but that still gives us two urls to the same content (descending or ascending, doesn't matter), resulting in an SEO penalty.

@jerone

jerone commented Feb 27, 2014

Copy link
Copy Markdown
Contributor

I suggest using the rel="canonical" meta on the default sorting page for XXX:

<link rel="canonical" href="http://openuserjs.org/scripts/sort/XXX" />

Throwing an 301 isn't really valid here.

@Zren

Zren commented May 16, 2014

Copy link
Copy Markdown
Contributor

Was there a specific reason for using route parameters rather than query string parameters?

@Martii
Martii deleted the issue-55 branch August 21, 2014 23:14
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

List user scripts on the homepage

3 participants