From 5fd2d8d83ceab78d00f65cc9dda9cfa3d11e98c5 Mon Sep 17 00:00:00 2001 From: yangjie01 Date: Wed, 18 Nov 2026 01:57:13 +0800 Subject: [PATCH] [mosaic] Reject TIMESTAMP(0) when validating Mosaic data fields --- .../format/mosaic/MosaicFileFormat.java | 13 ++++++ .../format/mosaic/MosaicFileFormatTest.java | 42 +++++++++++++++++++ 2 files changed, 55 insertions(+) diff --git a/paimon-mosaic/src/main/java/org/apache/paimon/format/mosaic/MosaicFileFormat.java b/paimon-mosaic/src/main/java/org/apache/paimon/format/mosaic/MosaicFileFormat.java index 6a1721d58fdc..1da47cd05416 100644 --- a/paimon-mosaic/src/main/java/org/apache/paimon/format/mosaic/MosaicFileFormat.java +++ b/paimon-mosaic/src/main/java/org/apache/paimon/format/mosaic/MosaicFileFormat.java @@ -215,11 +215,24 @@ public Void visit(TimeType timeType) { @Override public Void visit(TimestampType timestampType) { + // Precision 0 maps to the Arrow SECOND time unit, which the native + // mosaic writer cannot open a file with. + if (timestampType.getPrecision() == 0) { + throw new UnsupportedOperationException( + "Mosaic file format does not support type TIMESTAMP(0), " + + "use TIMESTAMP(3) instead"); + } return null; } @Override public Void visit(LocalZonedTimestampType localZonedTimestampType) { + if (localZonedTimestampType.getPrecision() == 0) { + throw new UnsupportedOperationException( + "Mosaic file format does not support type " + + "TIMESTAMP(0) WITH LOCAL TIME ZONE, " + + "use TIMESTAMP(3) WITH LOCAL TIME ZONE instead"); + } return null; } diff --git a/paimon-mosaic/src/test/java/org/apache/paimon/format/mosaic/MosaicFileFormatTest.java b/paimon-mosaic/src/test/java/org/apache/paimon/format/mosaic/MosaicFileFormatTest.java index df6fb385721b..15a4e26243d8 100644 --- a/paimon-mosaic/src/test/java/org/apache/paimon/format/mosaic/MosaicFileFormatTest.java +++ b/paimon-mosaic/src/test/java/org/apache/paimon/format/mosaic/MosaicFileFormatTest.java @@ -28,6 +28,7 @@ import org.junit.jupiter.api.Test; import java.util.ArrayList; +import java.util.Arrays; import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatThrownBy; @@ -98,6 +99,47 @@ void testValidateDataFieldsMapSupported() { format.validateDataFields(rowType); } + @Test + void testValidateDataFieldsTimestampPrecisionZeroUnsupported() { + MosaicFileFormat format = createFormat(); + for (RowType rowType : + Arrays.asList( + DataTypes.ROW(DataTypes.TIMESTAMP(0)), + DataTypes.ROW(DataTypes.ARRAY(DataTypes.TIMESTAMP(0))))) { + assertThatThrownBy(() -> format.validateDataFields(rowType)) + .isInstanceOf(UnsupportedOperationException.class) + .hasMessage( + "Mosaic file format does not support type TIMESTAMP(0), " + + "use TIMESTAMP(3) instead"); + } + for (RowType rowType : + Arrays.asList( + DataTypes.ROW(DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(0)), + DataTypes.ROW( + DataTypes.MAP( + DataTypes.STRING(), + DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(0))))) { + assertThatThrownBy(() -> format.validateDataFields(rowType)) + .isInstanceOf(UnsupportedOperationException.class) + .hasMessage( + "Mosaic file format does not support type " + + "TIMESTAMP(0) WITH LOCAL TIME ZONE, " + + "use TIMESTAMP(3) WITH LOCAL TIME ZONE instead"); + } + } + + @Test + void testValidateDataFieldsTimestampPositivePrecisionSupported() { + MosaicFileFormat format = createFormat(); + RowType rowType = + DataTypes.ROW( + DataTypes.TIMESTAMP(1), + DataTypes.TIMESTAMP(9), + DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(1), + DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(9)); + format.validateDataFields(rowType); + } + @Test void testValidateDataFieldsMultisetUnsupported() { MosaicFileFormat format = createFormat();