Repository navigation
ci: pin the release tooling installs OSSF Scorecard reports as unpinned #5837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0b1dd14
e026b59
2e910bb
79a057a
14ae45d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we set That should cascade all the way down to scripts and such, and we can de-duplicate |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -251,5 +251,20 @@ dev = [ | |
| "pre-commit", | ||
| "datamodel-code-generator[http]", | ||
| "datamodel-code-generator[ruff]", | ||
| { include-group = "towncrier" }, | ||
| ] | ||
| build = [ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. every single pyproject.toml in opentelemetry-python uses We also don't need build and pip anymore because we are going to use |
||
| "build", | ||
| "pip", | ||
| "setuptools", | ||
| "wheel", | ||
| ] | ||
| toml = [ | ||
| "toml", | ||
| ] | ||
| towncrier = [ | ||
| "towncrier", | ||
| ] | ||
| twine = [ | ||
| "twine", | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,12 +5,14 @@ | |
|
|
||
| set -ev | ||
|
|
||
| # Get the latest versions of packaging tools | ||
| python3 -m pip install --upgrade pip build setuptools wheel | ||
|
|
||
| BASEDIR=$(dirname "$(readlink -f "$(dirname $0)")") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should quote the variable expansion here: |
||
| DISTDIR=dist | ||
|
|
||
| # Get the versions of packaging tools recorded in the lockfile | ||
| uv sync --locked --only-group build --project "$BASEDIR" | ||
| PATH="$BASEDIR/.venv/bin:$PATH" | ||
| export PATH | ||
|
|
||
| ( | ||
| cd $BASEDIR | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same thing here: |
||
| mkdir -p $DISTDIR | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here: |
||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set this one time? instead of having it in every job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each job runs in it's own vm so I dont think it's possible.. maybe it could be moved to a template that each workflow imports but i'm not sure its worth it
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, but i noticed in -contrib we are running the commands through
uv run --no-syncinstead of doing this. Just wanted a common approach. anyway, don't want to block the PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah youre right.. we can get rid of this step completely and do
uv run --only-group towncrier towncrier