Repository navigation
Bugfix: Fix issue with interactive unzip on Linux - #807
Merged
Merged
Conversation
ericsciple
reviewed
May 12, 2021
ericsciple
reviewed
May 12, 2021
luketomlinson
force-pushed
the
bugfix/interactive-unzip
branch
from
May 14, 2021 18:17
70491f6 to
b31bbe5
Compare
luketomlinson
marked this pull request as ready for review
May 18, 2021 13:35
luketomlinson
commented
May 19, 2021
ericsciple
reviewed
May 21, 2021
ericsciple
reviewed
May 21, 2021
ericsciple
reviewed
May 21, 2021
ericsciple
approved these changes
May 21, 2021
|
Hi. This doesn't appear to be fully resolved.
|
Derrick-MUGISHA
pushed a commit
to Derrick-MUGISHA/toolkit
that referenced
this pull request
Oct 12, 2026
* Add new powershell commands for windows unzip * Test fails to overwrite file * Add new windows commands for unzip * Add Test for failing case for both pwsh and powershell * Modify test to confirm overwrite behavior for xar * Delete ._test.txt * Add fallback case for older windows systems * Remove try * Run Tests on windows-2016 * Update tar tests to handle existing files * Lint * Update tool-cache.test.ts * Update tool-cache.test.ts * Update tool-cache.test.ts * Update tool-cache.test.ts * Update from PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #456
Fixes issue where unzip would freeze when asking for interactive input.
This unifies the behavior across platforms to overwrite files instead of failing (windows, previously) or asking for user input (macOS and linux previously).