Repository navigation
Fix a flaky test failure - #14489
Merged
cfallin merged 1 commit intoOct 2, 2026
Merged
Fix a flaky test failure#14489
Conversation
The test add in bytecodealliance#14483 is causing failures in CI where a debug-style panic can be triggered depending on whether the host triggers a timeout or not. The fix here is to avoid asserting the result of a body write and to let the rest of the test determine if that was successful or not.
cfallin
approved these changes
Oct 2, 2026
cfallin
enabled auto-merge
October 2, 2026 17:07
This was referenced Oct 2, 2026
cfallin
pushed a commit
that referenced
this pull request
Oct 2, 2026
The test add in #14483 is causing failures in CI where a debug-style panic can be triggered depending on whether the host triggers a timeout or not. The fix here is to avoid asserting the result of a body write and to let the rest of the test determine if that was successful or not.
cfallin
pushed a commit
that referenced
this pull request
Oct 2, 2026
The test add in #14483 is causing failures in CI where a debug-style panic can be triggered depending on whether the host triggers a timeout or not. The fix here is to avoid asserting the result of a body write and to let the rest of the test determine if that was successful or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test add in #14483 is causing failures in CI where a debug-style panic can be triggered depending on whether the host triggers a timeout or not. The fix here is to avoid asserting the result of a body write and to let the rest of the test determine if that was successful or not.