Repository navigation
feat: capture Node.js trace categories via Perfetto - #52973
Merged
Merged
Conversation
* feat: capture Node.js trace categories via Perfetto * fix: crash in ELECTRON_RUN_AS_NODE * chore: cleanup macro usage * chore: update patches Backport notes: patches/node regenerated against this branch's Node (v24.18.1); build_enable_perfetto.patch content is identical to the original change, the other node patch updates are index/offset only. (cherry picked from commit c0f187f)
MarshallOfSound
enabled auto-merge (squash)
August 19, 2026 07:21
MarshallOfSound
approved these changes
Aug 19, 2026
|
Release Notes Persisted
|
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50591
See that PR for details.
Manual backport notes:
patches/nodewas regenerated against this branch's Node (v24.18.1) rather than text-merged: 42-x-y's series plus the newbuild_enable_perfetto.patchwere applied to a v24.18.1 tree (one context fix-up inunofficial.gniforchore_exclude_electron_node_folder_from_exit-time-destructors.patch) and re-exported withscript/lib/git.py. The resultingbuild_enable_perfetto.patchcontent is identical to the original change; the other node patch diffs are index/offset-only. The chromium and v8 patches are unchanged from the original (this branch is on the same Chromium major the original landed against) and apply cleanly to 148.0.7778.280. The spec additions are appended to this branch's largerapi-content-tracing-spec.ts. Supersedes the earlier trop attempt #50885 (approved, then closed as stale).Notes: Fixed contentTracing module to capture Node.js trace categories.