Repository navigation
Fix CLI validation for startBlock and contractName fetched from external APIs - #1767
Merged
0237h merged 1 commit intoNov 19, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 1a3a638 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Specifically for `startBlock` and `contractName`.
0237h
force-pushed
the
fix/confirm-etherscan-fetched-entries
branch
from
November 19, 2024 17:44
55061c8 to
1a3a638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a value was retrieved via Etherscan-like APIs for
startBlockandcontractName, their value couldn't be overwritten by the user in the prompt.This change corrects that behavior. The prompt can still be skipped by passing those values from the
initcommand line directly (e.g.--start-block=<value>).