Repository navigation
fix(NcEmptyContent): use name as label - #7634
Merged
Merged
Conversation
susnux
marked this pull request as ready for review
October 8, 2025 12:22
> Naming a note is optional, but can help screen reader users understand its context and purpose So its not required but it was a breaking change when we made the `name` not a heading anymore (while still it was an a11y fix). But now the note is not really identifiable when using a11y-api, so we need to use the name as the label. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/empty-content-header
branch
from
October 8, 2025 12:27
fda138a to
1a52197
Compare
Contributor
Author
|
/backport to stable8 |
ShGKme
reviewed
Oct 8, 2025
max-nextcloud
approved these changes
Oct 9, 2025
Contributor
There was a problem hiding this comment.
Only checked the code as I know to little about the context to judge if this change makes sense.
Asking @JuliaKirschenheuter for review as an a11y expert.
ShGKme
approved these changes
Oct 13, 2025
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Fine by me, but in the future I'd avoid having additional hidden changes even when they don't seem a problem.
2 tasks done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
So its not required but it was a breaking change when we made the
namenot a heading anymore (while still it was an a11y fix). But now the note is not really identifiable when using a11y-api, so we need to use the name as the label.🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable