Skip to content

fix: Use Typescript source files for types - #262

Merged
skjnldsv merged 1 commit into
masterfrom
fix/types
Jul 4, 2024
Merged

skjnldsv merged 1 commit into
masterfrom
fix/types

Conversation

@susnux

@susnux susnux commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Somehow Typescript changed to only include /// <reference comments if they are needed within the source file. In our case this means we have an empty Typescript definitions files because we only "export" them.

Solution: Export our types from the source.

Somehow Typescript changed to only include `/// <reference` comments
if they are needed within the source file. In our case this means we have
an empty Typescript definitions files because we only "export" them.

Solution: Export our types from the source.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels Jul 2, 2024
@susnux
susnux requested review from ChristophWurst and skjnldsv July 2, 2024 09:06
@susnux

susnux commented Jul 2, 2024

Copy link
Copy Markdown
Contributor Author

PS: This means the current 1.9.0 release is completely broken :(

@skjnldsv
skjnldsv merged commit 5ea5e4f into master Jul 4, 2024
@skjnldsv
skjnldsv deleted the fix/types branch July 4, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants