Skip to content

feat: migrate code base to TypeScript - #175

Merged
JounQin merged 8 commits into
masterfrom
feat/ts
Jan 16, 2024
Merged

JounQin merged 8 commits into
masterfrom
feat/ts

Conversation

@JounQin

@JounQin JounQin commented Jan 16, 2024

Copy link
Copy Markdown
Member

No description provided.

@JounQin JounQin added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 16, 2024
@JounQin JounQin self-assigned this Jan 16, 2024
@changeset-bot

changeset-bot Bot commented Jan 16, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 18a49b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pretty-quick Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci

codesandbox-ci Bot commented Jan 16, 2024 •

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions

github-actions Bot commented Jan 16, 2024 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
src/index.js 0 B (-100% 🔽)
src/index.ts 955 B (+100% 🔺)

@codecov-commenter

codecov-commenter commented Jan 16, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0ae06f1) 85.03% compared to head (356ee99) 88.60%.

Files Patch % Lines
src/processFiles.ts 78.94% 4 Missing ⚠️
src/index.ts 87.50% 2 Missing ⚠️
src/scms/git.ts 89.47% 2 Missing ⚠️
src/scms/hg.ts 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   85.03%   88.60%   +3.56%     
==========================================
  Files           8        8              
  Lines         127      158      +31     
  Branches       48       46       -2     
==========================================
+ Hits          108      140      +32     
  Misses         15       15              
+ Partials        4        3       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin
JounQin merged commit 4f5a345 into master Jan 16, 2024
@JounQin
JounQin deleted the feat/ts branch January 16, 2024 15:19
Comment thread src/index.ts
// @ts-expect-error -- TODO: check
revision,
)
.filter(isSupportedExtension(resolveConfig))

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug found by TypeScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants