Repository navigation
Linter fixes - #381
Merged
Merged
Linter fixes#381
Conversation
Contributor
Author
|
@dbale-altoros can i haz approval for workflow so I know if I have something to fix? |
Collaborator
|
@juanpcapurro done |
Collaborator
|
@juanpcapurro |
Closed
automated fixes only
- max-classes-per-files wasn't really enforced and at a presonal level I don't see it making the code all that clearer - fixed some requires that innecessarily included the .js at the end of filenames
so we don't merge PRs that break linter conventions
juanpcapurro
force-pushed
the
linter-fixes
branch
from
January 23, 2023 15:35
c899d0c to
ae9ccfd
Compare
Contributor
Author
|
@dbale-altoros this PR is rebased on top of current master and ready for review again ✨ |
dbale-arg
approved these changes
Jan 25, 2023
Collaborator
GREAT! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider configuring github merge to do a linear/semi-linear history on merge preserving history so: