Skip to content

Repoint the Devcontainer Snippets at Images That Start - #3866

Merged
ptr727 merged 2 commits into
developfrom
fix/devcontainer-snippet-images
Nov 4, 2026
Merged

ptr727 merged 2 commits into
developfrom
fix/devcontainer-snippet-images

Conversation

@ptr727

@ptr727 ptr727 commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Part of #3858.

Why

Neither catalog devcontainer snippet starts.

  • python:1-3.14-bookworm is absent from the registry, and major 1 of that image holds no Python 3.14 tag at all. The issue reads as a tag that disappeared, but the registry shows no sign this one ever existed.
  • dotnet:1-10.0 still exists, but its common-utils feature build fails on the image's yarn apt source.

What Changed

  • The Python snippet moves to python:3-3.14-bookworm and the .NET snippet to dotnet:2-10.0.
  • docs/devcontainer.md updates its table and states how the tags stay current.

How the tags stay current: by hand, with the reason stated in the doc. Dependabot's devcontainers ecosystem updates Features. GitHub's supported-ecosystems page and containers.dev describe no image update, and the docker ecosystem's documented scope does not name devcontainer.json. So a Dependabot entry would not have moved these tags. Each tag floats within its image major, so it takes that major's updates without an edit.

Verification

Each snippet ran through devcontainer up with post-create, using the Dev Containers extension's bundled CLI (0.469.0) on Docker Desktop's WSL2 backend. Each ran from a scratch tree holding the definition under .devcontainer/<language>/, against a synthetic home, after a docker pull and with --build-no-cache.

Image Result Post-create
dotnet:1-10.0 exit 1, NO_PUBKEY on dl.yarnpkg.com, which confirms the issue's cached result on a fresh pull not reached
dotnet:2-10.0 exit 0, .NET SDK 10.0.403 dotnet tool restore restored a synthetic manifest naming CSharpier
python:3-3.14-bookworm exit 0, Python 3.14.10 on Debian bookworm uv 0.11.8 installed, uv sync --frozen ran on a synthetic project

The prose gate passes over the diff. The full test suite was not run, since no tracked file other than these three names the old tags and the change touches no code.

Not in This Change

Pre-existing findings, not filed

  • catalog/snippets/configs/dependabot.yml:16 (pre-existing): the code-shipping reference config has no devcontainers pair, while the audit reports drift for a repository holding .devcontainer/ with that ecosystem undeclared. A repository copying the reference learns this from the audit, whose finding names the fix.

🤖 Generated with Claude Code

The Python snippet named a tag the registry does not hold, and major 1 of that image has no Python 3.14 tag at all.
The .NET snippet's tag still exists, but its feature build fails on the image's yarn apt source, on a fresh pull as well as a cached one.

Dependabot's devcontainers ecosystem updates Features and its documented scope excludes an image tag, so docs/devcontainer.md states the tags are kept by hand.
Copilot AI lite review requested due to automatic review settings November 4, 2026 17:07
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ptr727

ptr727 commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 8903497fe2e9f467f8cbe770ce990060c2268f72, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the affected Dev Container tags and maintenance guidance have been updated.

No open issues 🎉

What changed in this PR

This PR repoints the Python and .NET Dev Container snippets to image tags that start successfully and updates the related maintenance documentation.

Changes:

  • Updates Python to 3-3.14-bookworm.
  • Updates .NET to 2-10.0.
  • Documents manual tag maintenance and verification guidance.
  • Notes that scratch-tree instructions should also include the referenced post-create script.

This pull request is ready to be approved.

File Summary
docs/​devcontainer.md Updates the image table, tag-maintenance guidance, and verification instructions.
catalog/​snippets/​devcontainer/​python/​devcontainer.json Selects the Python 3.14 image tag that starts successfully.
catalog/​snippets/​devcontainer/​dotnet/​devcontainer.json Selects the .NET 10 image tag whose feature build succeeds.

Review effort: Lite

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.31%. Comparing base (87c05af) to head (8903497).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3866   +/-   ##
========================================
  Coverage    83.31%   83.31%           
========================================
  Files           29       29           
  Lines         9956     9956           
========================================
  Hits          8295     8295           
  Misses        1661     1661           
Flag Coverage Δ
python-3.13 83.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 50f91b8 into develop Nov 4, 2026
14 checks passed
@ptr727
ptr727 deleted the fix/devcontainer-snippet-images branch November 4, 2026 17:20
ptr727 added a commit that referenced this pull request Nov 4, 2026
…3868)

Part of #3860.

## Why

Each catalog devcontainer snippet declared its public key and
`allowed_signers` mounts in the object form with `"readonly": true`. The
Dev Containers CLI drops that key, so both host files were writable from
inside the container. `allowed_signers` is the file `git verify-commit`
and `git log --show-signature` trust, so a process in the container
could add a signer that outlives the container. `docs/devcontainer.md`
called both mounts read-only.

## What Changed

- Each snippet declares its mounts in the string form, the route the
[Dev Container metadata
reference](https://containers.dev/implementors/json_reference/)
documents as taking the same values as Docker's `--mount` flag. The `gh`
config mount moves with them, so the list holds one form, and it stays
read-write.
- `docs/devcontainer.md` states why the string form is used, so a later
tidy does not restore the object form. Its mode table was already what
the mounts should do, and now matches what they do.

## Verification

Each snippet ran through `devcontainer up` with post-create, using the
Dev Containers extension's bundled CLI (0.469.0) on Docker Desktop's
WSL2 backend, from a scratch tree and a synthetic home.

| Check | Before, on #3866's images | After, Python | After, .NET |
| --- | --- | --- | --- |
| `id_ed25519.pub` in `docker inspect` | `RW=true` | `RW=false` |
`RW=false` |
| `allowed_signers` in `docker inspect` | `RW=true` | `RW=false` |
`RW=false` |
| `.config/gh` in `docker inspect` | `RW=true` | `RW=true` | `RW=true` |
| Append to each read-only file as `vscode` | not run here, the issue
measured it succeeding | refused | refused |
| Create and remove a file in `.config/gh` | not run | works | works |
| Lines in the host's files afterward | not run | unchanged | unchanged
|

`up` exited 0 for each snippet, so the read-only mounts break neither
the feature build nor post-create. The full test suite was not run,
since no test parses these mounts and the change touches no code.

**Not measured:** a commit signed and verified in the container with
these mounts. The synthetic home holds no real key, so this probe shows
the signers file is readable at its path and refuses a write, and stops
there.

## Not in This Change

- `ptr727/ESPHome-Config` carries the Python snippet's old mount lines,
so its host files stay writable until a resync reaches it.
- #1763 touches the same `mounts` lines and rebases over this.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
ptr727 added a commit that referenced this pull request Nov 4, 2026
#3870)

## Summary

Promotes #3866 and #3868 to `main`.

Closes #3858.
Closes #3860.

- **#3866** repoints the catalog devcontainer snippets at images that
start, `python:3-3.14-bookworm` and `dotnet:2-10.0`. It also documents
why those tags are kept by hand.
- **#3868** moves the snippets' mounts to the string form, so the public
key and `allowed_signers` mounts are read-only rather than writable from
the container.

Each snippet was started with post-create on a Windows host's Docker
Desktop, from a scratch tree and a synthetic home. Each feature pull
request's body holds that measurement.

`ptr727/ESPHome-Config` carries the Python snippet with both defects,
and stays as it is until a resync reaches it.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants