[ehmicky]

Fixes #1143.

This PR does not add any documentation because this is a very tiny edge case that almost nobody will encounter:

• Running Node.js without ICU support requires building your own Node.js binary. No pre-built binary without ICU support seems to be available.
• Then, the user would need to use very special characters in the command, such as isolated surrogate characters or reserve Unicode codepoints (which is quite unlikely) to notice any difference.
• Even then, the only difference would only be that those special characters would be printed as is on the terminal (when using result.escapedCommand) instead of being represented as a backslash sequence \u..., which is not a big problem.

[ehmicky]

I cannot find a simple way to run tests using Node without ICU support. So this mimics it for our purpose.

[ehmicky]

We could mock/unmock RegExp directly in escape.js, and run each test twice. But then each test would need to be serial. Also it makes the test file a little complex (this was my first approach). Using a separate test file that imports the other one results in less code.

[Uzlopak]

When will it be released? :)

[ehmicky]

This has now been released in 9.3.1. Thanks again for your help.

Is this working?

[Uzlopak]

Thank you. Yes :). Great Success.

PS:
https://x.com/uzlopak_js/status/1823796028182814975

[ehmicky]

Thanks for the shout out @Uzlopak, that's very kind! 🙏

[Uzlopak]

Unfortunately, you are not on twitter, or else I would have linked you.