Repository navigation
Type the std* generator transform chunk argument - #1247
Merged
Merged
Conversation
The `transform` generator function's `chunk` argument was typed as `unknown`, which forcd users to annotate it as `unknown` and rejected a `(line: string) =>` transform. Its type is now based on the transform's mode: `string` for line transforms, `Uint8Array` when `binary: true`, and `unknown` when `objectMode: true`. A binary `encoding` (`'buffer'`, `'hex'`, `'base64'`, etc.) also makes the `chunk` a `Uint8Array`, since the subprocess output is binary in that case. Fixes #694
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
transformgenerator function'schunkargument was typed asunknown, which forcd users to annotate it asunknownand rejected a(line: string) =>transform. Its type is now based on the transform's mode:stringfor line transforms,Uint8Arraywhenbinary: true, andunknownwhenobjectMode: true.A binary
encoding('buffer','hex','base64', etc.) also makes thechunkaUint8Array, since the subprocess output is binary in that case.Fixes #694