Repository navigation
Fix using both objectMode and encoding options - #736
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes using both:
objectModeencodingoption with values likehexorbase64When a transform in
objectModereturns an object,encoding: 'base64'should be a noop.When a transform in
objectModereturns a string or anUint8Array,encoding: base64can work. However, it must operate chunk-wise instead of line-wise, since consumers of streams inobjectModemight assume for emitted chunks to be independent from each other. For example, we will make that assumption with #706: we will emit one line at a time inobjectMode, and would assume to be encoded separately from the next one.