Repository navigation
Strip newlines in transforms - #919
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves how newlines are handled in transforms:
lineargument passed to transformsyield stringstatements do not need to add a newline at the end ofstringanymore. Eachyieldproduces a new line (kindof likeconsole.log()).The above behavior can be disabled by passing a
{transform, newline: true}plain object.As an added bonus, the
stripFinalNewlineoption now works with thelinesoption. Iflines: trueis used, andstripFinalNewline: trueis used too, it will be applied to each line, i.e. each item of theresult.stdout/result.stderrarray.