Repository navigation
Improve handling of encoding option - #926
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our logic changes based on whether the subprocess output is binary or not: the
linesoption, transforms,subprocess.readable(),subprocess.duplex()andsubprocess.iterable().We currently detect this by checking if the
encodingoption isbuffer. However, if it ishex, it almost certainly also means the output is binary. The same applies tobase64,base64url,latin1andascii(those last 2 are improperly named, they are actually ways to represent binary data in text form).This PR fixes this.
It also improves the documentation and testing of the
encodingoption.