Repository navigation
Change casing of utilities with named values to kebab-case to match u… - #18017
Merged
Merged
Conversation
philipp-spiess
force-pushed
the
fix/casing-named-values
branch
2 times, most recently
from
May 14, 2025 11:28
6d6550c to
052f362
Compare
RobinMalfait
left a comment
Contributor
There was a problem hiding this comment.
Yeah makes sense! I just think we should add an integration test to verify named modifiers.
Another thing is named modifiers for variants, like a named group/foo and then you can use it as group-hover/foo, but this is only updating the actual base candidate not the variants so I think we're good!
| 400: '#f87171', | ||
| 500: 'red', | ||
| }, | ||
| superRed: '#ff0000', |
Contributor
There was a problem hiding this comment.
Can we also add a test to ensure that a named modifier is actually converted to kebab-case as well?
philipp-spiess
force-pushed
the
fix/casing-named-values
branch
from
May 14, 2025 11:43
eeb65b2 to
ac9920d
Compare
…pdated theme variables
philipp-spiess
force-pushed
the
fix/casing-named-values
branch
from
May 14, 2025 11:45
ac9920d to
b3f34ed
Compare
RobinMalfait
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16156
Summary
This PR adds a new 3 -> 4 template migration that changes the casing of in both utility values and modifier values from camelCase to kebab-case to match the updated CSS variable names.
Test plan