Repository navigation
Fix missing extracted classes containing . in Clojure - #18038
Merged
Merged
Conversation
. in Clojure. in Clojure
RobinMalfait
force-pushed
the
fix/issue-17760
branch
from
May 15, 2025 12:07
e765e88 to
446310f
Compare
RobinMalfait
enabled auto-merge (squash)
May 15, 2025 12:12
philipp-spiess
approved these changes
May 15, 2025
Contributor
|
Thanks @RobinMalfait, can confirm that these things work well now! I ran into another issue with pseudo classes though. Eg. By the way, the debugger that you're sharing screenshots from: is it accessible publicly? It would be great to try verify things like this before reporting them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the Clojure pre-processor where candidates including
.characters were not extracted correctly.The solution here is to only replace the
.with a.is not surrounded by numbers. This means that:Becomes
But
Becomes
This way the
gap-1.5is correctly extracted.Test plan
gap-1.5is correctly extracted here.Fixes: #17760