Repository navigation
Net benchmarks fail to build #6405
Description
- Version: v7.0.0-pre (@master)
- Platform: OS X 10.11.4
- Subsystem: Benchmark
Running make bench results in the output:
net/net-c2s-cork.js
_stream_readable.js:19
return emitter.prependListener(event, fn);
^
TypeError: emitter.prependListener is not a function
at prependListener (_stream_readable.js:19:20)
at Socket.Readable.pipe (_stream_readable.js:582:3)
at Server.<anonymous> (<node_dir>/benchmark/net/net-c2s-cork.js:71:12)
at emitOne (events.js:96:13)
at Server.emit (events.js:188:7)
at TCP.onconnection (net.js:1452:8)
child process exited with code 1
Activity
jasnell commentedon Apr 27, 2016
Ugh... ok, yeah, it looks like those benchmarks are doing some funny things with the event emitter interface. Good catch, will have to spend some time to figure that one out.
matthewloring commentedon Apr 27, 2016
@jasnell Putting together a potential fix now. I'm looking for more input but I think
prependEmittercan be mocked out just likeemit,on, etc for these benchmarks.Trott commentedon Apr 27, 2016
/cc @mcollina
mcollina commentedon Apr 27, 2016
The structure of these benchmark was already there. They probably need an overhaul anyway.
BTW, we should make sure that the benchmarks are part of the CI thing, not to take actual measurement, but on the fact that they "work".
jasnell commentedon Apr 27, 2016
Yeah I was thinking the same thing. The challenge is that some of the
benchmarks are fairly intensive. However, during release prep, there should
be an option to include benchmarks in a CI run. /cc @nodejs/build
On Apr 27, 2016 2:07 AM, "Matteo Collina" notifications@github.com wrote:
jasnell commentedon Apr 30, 2016
Fix landed in #6407