Repository navigation
Update to AngleSharp 1.10.2 and mark the library trim and Native AOT compatible - #55
Open
michaelthyregod wants to merge 2 commits into
Open
michaelthyregod wants to merge 2 commits into
michaelthyregod wants to merge 2 commits into
Conversation
…compatible - AngleSharp 1.8.6 -> 1.10.0; the tests use AngleSharp.Xml 1.3.0 - IsAotCompatible on the .NET 8+ targets turns on the trim, single-file and AOT analyzers: no warnings on any target, and a Native AOT publish of an app using SelectNodes and WithXPath is warning-free - every target uses the SDK's own ILLink.Tasks, as in AngleSharp.Xml and AngleSharp.Css, so the package isn't restored in two versions
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsAotCompatibleon the .NET 8+ targets turns on the trim, single-file and AOT analyzers. There are no warnings on any target, and a Native AOT publish of an app usingSelectNodesandWithXPath()is warning-free.Microsoft.NET.ILLink.Tasks(the sameKnownILLinkPackline as AngleSharp.Xml and AngleSharp.Css), so the package isn't restored in two versions for net8.0 and net10.0.All 14 tests pass.
🤖 Generated with Claude Code