Repository navigation
Raise the minimum AngleSharp version to 1.9.1 - #45
Closed
michaelthyregod wants to merge 1 commit into
Closed
michaelthyregod wants to merge 1 commit into
michaelthyregod wants to merge 1 commit into
Conversation
1.9.1 contains AngleSharp/AngleSharp#1401, which makes AppendChild into deep trees constant time.
FlorianRappl
reviewed
Nov 2, 2026
FlorianRappl
left a comment
Contributor
There was a problem hiding this comment.
Why? The minimum version is what you at least require. Just because there is an improvement in AngleSharp should not force you to upgrade.
The only reason for raising the minimum version is if some API is not yet available.
Contributor
Author
|
Fair point, nothing here needs 1.9.1; the speedup comes for free to anyone on it. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the minimum AngleSharp version to 1.9.1 for 1.3.0, as agreed on #43. 1.9.1 contains AngleSharp/AngleSharp#1401, which makes
AppendChildinto deep trees constant time instead of O(depth).Change
src/AngleSharp.Xml/AngleSharp.Xml.csproj: the defaultAngleSharpVersiongoes from 1.9.0 to 1.9.1. Versions below 2.0.0 are still allowed..github/workflows/ci.yml: all four-AngleSharpVersionvalues are now 1.9.1.AGENTS.md: the defaults and CI lines say 1.9.1, and the Performance note saysAppendChildwas O(depth) up to 1.9.0.CHANGELOG.md: "Updated to use a minimum of AngleSharp 1.9.1".Verification
The benchmark results for 1.3.0 follow tonight on #43.
🤖 Generated with Claude Code