Skip to content

build.sh: follow a symlinked JAR_LIB_DIR #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tae898 merged 1 commit into from
Oct 24, 2026
Merged

build.sh: follow a symlinked JAR_LIB_DIR #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ARCADEDB_TAG=26.11.1-SNAPSHOT ./scripts/build.sh # pin the arcadedata/arcaded

- Linux builds use `scripts/Dockerfile.build`; macOS/Windows use `scripts/build-native.sh` with a native JDK 25+ (jlink).
- Jars come from the `arcadedata/arcadedb` Docker image, filtered by `scripts/jar_exclusions.txt`, staged by `scripts/stage_jars.sh` (always re-pulled; stale jars from a previous build are removed).
- `JAR_LIB_DIR` (third argument) may be a symlink, and so may any jar in it: `build.sh` follows both and stages real files into `local-jars/`.
- The package version is derived from the `arcadedb-engine-<version>.jar` (`scripts/extract_version.py`): `26.11.1-SNAPSHOT` → `26.11.1.devN`. The `version = "0.0.0"` in `pyproject.toml` is a placeholder overwritten at build time.
- `src/java/com/arcadedb/python/*.java` is compiled during the build into `arcadedb-python-bridge.jar` (both in `Dockerfile.build` and `build-native.sh`). Changing Java code requires a rebuild.
- Output: `dist/*.whl`. `setup.py` only exists to force a platform-specific wheel tag.
Expand Down
8 changes: 6 additions & 2 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ if [[ -n "$JAR_LIB_DIR" ]]; then
exit 1
fi

if ! find "$JAR_LIB_DIR" -maxdepth 1 -name "*.jar" -print -quit | grep -q .; then
# -H: find does not follow a symlinked starting point on its own, so a JAR_LIB_DIR that is
# a symlink to a directory looked empty and failed with "No JAR files found".
if ! find -H "$JAR_LIB_DIR" -maxdepth 1 -name "*.jar" -print -quit | grep -q .; then
echo -e "${RED}❌ No JAR files found in: ${JAR_LIB_DIR}${NC}"
exit 1
fi
Expand All @@ -183,7 +185,9 @@ if [[ -n "$JAR_LIB_DIR" ]]; then
echo -e "${CYAN}📦 Using provided JAR directory: ${YELLOW}${JAR_LIB_DIR}${NC}"
rm -rf "$LOCAL_JARS_DIR"
mkdir -p "$LOCAL_JARS_DIR"
cp -a "$JAR_LIB_DIR"/*.jar "$LOCAL_JARS_DIR"/
# -L: a jar that is itself a symlink is staged as a file. A copied link would dangle in the
# Docker build context and the hash below (find -type f) would skip it.
cp -aL "$JAR_LIB_DIR"/*.jar "$LOCAL_JARS_DIR"/
JAR_SOURCE_DESC="${JAR_LIB_DIR} (staged into local-jars)"
fi

Expand Down
Loading