Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTableSegmentsaccepts aTableRefand returnsElementSegmentRef[], matching Binaryen's JavaScript implementation and its existing core kitchen-sink test. The current declaration accepts a table name and claims to return names, so valid reference callers fail type checking while an incorrectly accepted string call can silently return no segments. This corrects the declaration and adds a typed caller plus a runtime regression that filters two tables and resolves returned element references.Validation:
npm testpasses with the repository's locked TypeScript 4.9.5 and Node 24.14.0. The new typed caller fails against the original declaration and passes after the fix; it also rejects the unsupported string call and string-array result assumption.Generated and tested with Codex. The runtime contract was checked against Binaryen main, release 132, and the distributed 132.0.0 JavaScript build.