Repository navigation
feat(valgrind): always enable deterministic RNG - #600
not-matthias wants to merge 3 commits into
Conversation
Merging this PR will degrade performance by 13.13%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
[Medium impact] No additional changes are requested beyond the Valgrind release prerequisite already documented by the author. SummaryAdds
Reviews (1) · Last reviewed commit: "feat(valgrind): always enable determinis..." · Reviewed by Greptile |
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
lgtm, I think all thee commits can be squashed though 🙈
Always pass
--deterministic-rng=yesto valgrind in simulation mode, so AT_RANDOM,getrandom(),/dev/urandomand hardware RNG instructions return fixed values. This removes one source of run-to-run variance.Blocked on a valgrind-codspeed release: the currently pinned
3.26.0-0codspeed10does not know--deterministic-rngand would reject it. The pin must be bumped before this merges.Closes COD-4083
I suggest merging this and releasing a new beta to properly test the feature