Skip to content

JavaScript warnings on Array, Object-type methods does not respect function parameter defaults #73

Open

Description

@mschlitz-trux

Using this example code below:

_renderAttachments(attachments = []) {
    return attachments.map((attach) => {

DeepCode will warn that calling .map() on non array object for attachments will not work.
It suggests to use (attachments || []). While this is correct, it does not account for the function parameter default value which is already provided.

In the above case, the function already provides a fallback for (attachments = []), so the suggested change would offer no further benefit.

This also occurs for things like Object fallbacks (attachments = {}), or es6 Object types such as (attachments = new Map())

Activity

  1. deepcodeg commented on Jan 13, 2021

    @deepcodeg
    Contributor

    @mschlitz-trux 👋, just checked with the AI team, this should be fixed, could you please check on your end if this is the case?

  2. mschlitz-trux commented on Jan 14, 2021

    @mschlitz-trux
    Author

    Thanks, I'm still trying to check. The extension constantly crashing for me in VSCode the past few days, so I cannot confirm this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions