Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepen notes
454921cf0765f51d5c74648ed7b91f3ce83837a4: AGENTS.md:271 and scripts/README.md:48.1d5f0709ebefd405a5d2d26effe7867b48945054, with no actionable findings. The review also independently passedgit diff --check. The acceptance record records that verdict and exact head.just ci-local-prepushpassed on that head (exit 0), including 1,830 JavaScript checks and the release/tooling fixtures. The enabled Git pre-push hook also passed on the same head (exit 0). Both final fetches confirmedbase-rule=contains-develop.Authors will record their expert view, primary evidence, method and independent check before a substantive change, then adjust their plan. Corrections follow code, automatic check, written rule, and human detection last.
Related to #486. This PR stays draft for Anders's decision.
Local gate evidence:
Local pre-push gate passed for 1d5f0709ebefd405a5d2d26effe7867b48945054.Validation: product-data validation and all 99 product-data tests passed;
git diff --checkand both required Rust formatting checks passed. This change affects agent instructions only, so installed product acceptance does not apply.The branch contains one commit above frozen
develop(454921cf0765f51d5c74648ed7b91f3ce83837a4). The task worktree is retained for this review; cleanup follows PR merge or closure, with branch-owner agreement and the repository's preservation checks.CI evidence: run 40174064014 passed on GitHub's synthetic merge
6f5ea7026a4c9ac8c21bf4fa59489743dbdfd17f, whose tree matches the reviewed head. Source, audit, lint, behaviour, runtime/capsule tests, macOS and both Linux installed-home jobs, and Linux update-hop passed. The acceptance record records the exact identities and path-based skips. Anders's draft and template decisions remain.