Skip to content

docs: require Deepen notes before substantive changes - #490

Draft
andersalm wants to merge 1 commit into
developfrom
feat/486-deepen-notes
Draft

andersalm wants to merge 1 commit into
developfrom
feat/486-deepen-notes

Conversation

@andersalm

@andersalm andersalm commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Deepen notes

  1. Expert view: Keep the policy in AGENTS.md and make it easy to apply. I recommend a small PR template with the four headings and a link to this rule, so the block appears by default. Anders decides that addition in review; this draft changes AGENTS.md.
  2. Raw material: Start from Anders's original request in #486 and the frozen source 454921cf0765f51d5c74648ed7b91f3ce83837a4: AGENTS.md:271 and scripts/README.md:48.
  3. Methods: Compare all four questions and the correction order with the original request; inspect the complete Markdown diff, keep the existing review rules, and run the repository's formatting, product-data and pre-push checks.
  4. Independent check: The independent Codex reviewer in the OMP chat compared the original instruction, Agent instructions: Deepen notes before non-trivial code changes #486 and the full committed file, and returned PASS on 1d5f0709ebefd405a5d2d26effe7867b48945054, with no actionable findings. The review also independently passed git diff --check. The acceptance record records that verdict and exact head. just ci-local-prepush passed on that head (exit 0), including 1,830 JavaScript checks and the release/tooling fixtures. The enabled Git pre-push hook also passed on the same head (exit 0). Both final fetches confirmed base-rule=contains-develop.

Authors will record their expert view, primary evidence, method and independent check before a substantive change, then adjust their plan. Corrections follow code, automatic check, written rule, and human detection last.

Related to #486. This PR stays draft for Anders's decision.

Local gate evidence: Local pre-push gate passed for 1d5f0709ebefd405a5d2d26effe7867b48945054.

Validation: product-data validation and all 99 product-data tests passed; git diff --check and both required Rust formatting checks passed. This change affects agent instructions only, so installed product acceptance does not apply.

The branch contains one commit above frozen develop (454921cf0765f51d5c74648ed7b91f3ce83837a4). The task worktree is retained for this review; cleanup follows PR merge or closure, with branch-owner agreement and the repository's preservation checks.

CI evidence: run 40174064014 passed on GitHub's synthetic merge 6f5ea7026a4c9ac8c21bf4fa59489743dbdfd17f, whose tree matches the reviewed head. Source, audit, lint, behaviour, runtime/capsule tests, macOS and both Linux installed-home jobs, and Linux update-hop passed. The acceptance record records the exact identities and path-based skips. Anders's draft and template decisions remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant