Repository navigation
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
@MelvinBot why is |
…n into claude-bumpPlaywright
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Bumps
@playwright/test^1.43.1→^1.64.1(playwright/playwright-core1.51.1 → 1.64.1) to fix GHSA-7mvr-c777-76hp (browser downloads skipped SSL cert checks; patched in 1.55.1).Usage: Dev-only. Runs the web E2E tests in
WebExample/__tests__(npm run test) against the Expo web example, in CI viaweb-e2e-test.yml. Not shipped in the library.Lockfile was updated by hand (
npm civalidated; all three packages resolve to 1.64.1). No listed breaking changes affect our tests (they usepage.click/evaluate/goto/waitForTimeout).Change Log
toContainClass(),failOnFlakyTests; glob?/[]dropped inpage.route.locator.describe().cookie.partitionKey,--user-data-dirCLI; Node 16 dropped.testStepInfo.titlePath; Chromium MV2 extensions dropped; SSL fix for browser downloads.backgroundpagedeprecated.page.accessibilityremoved._react/_vueselectors anddevtoolslaunch option removed.await using; WebKit macOS 14 dropped.test.abort(); deprecated APIs removed (videosPath, etc.).locator.within(), better videos; devicescreennow emulated; Node ≥20 required (repo uses 24).Related Issues
$ https://github.com/Expensify/Expensify/issues/695659
Manual Tests
npm ciat repo root.npx playwright --version→1.64.1.npx playwright install --with-depssucceeds.cd WebExample && npm run test→ all specs pass on Chromium, Firefox, WebKit.Test web E2ECI check passes on this PR.Linked PRs