Lost compatibility with latest release of pre-commit #18

Activity

1. amureki commented on Aug 6, 2017

   

   amureki

   on Aug 6, 2017

   More actions

   @Alain1405 there was code update, fixing this #17 but release was not published.
   We can ask @cknv for releasing it, until then you can directly point pre-commit to use latest commit, like this:

   -   repo: git:https://github.com/FalconSocial/pre-commit-python-sorter
       sha: b57843b0b874df1d16eb0bef00b868792cb245c2
       hooks:
       -   id: python-import-sorter
           language: system
   

   👍React with 👍6Reacted by Ryan Lopopolo, Alain Scialoja, anthony sottile, Greg Back, Benjamin Balder Bach and Fang-Pen Lin
2. gtback commented on Aug 18, 2017

   

   gtback

   on Aug 18, 2017

   More actions

   I believe all that's needed is a new tag on GitHub. Later versions of pre-commit break when trying to run pre-commit autoupdate. ☹️

   👍React with 👍1Reacted by Daisy Leigh Brenecki
3. Alain1405 commented on Aug 18, 2017

   

   Alain1405

   on Aug 18, 2017

   Author

   More actions

   @gtback @amureki's solution works as a temporary fix.
   @cknv could you create another release?
4. gtback commented on Aug 21, 2017

   

   gtback

   on Aug 21, 2017

   More actions

   I just learned I can pre-commit autoupdate --bleeding-edge to get the latest (tagged or not) commit in all hook repos, which also works for pre-commit-python-sorter. But a new release would be much appreciated, @cknv ! 😀
5. daisylb commented on Sep 24, 2017

   

   daisylb

   on Sep 24, 2017

   More actions

   I've forked this repo and tagged the latest commit at https://github.com/adambrenecki/pre-commit-python-sorter, so that autoupdate still works with it without having to use --bleeding-edge on all my repos.

   👍React with 👍1Reacted by Benjamin Balder Bach
6. benjaoming commented on Nov 22, 2017

   

   benjaoming

   on Nov 22, 2017

   More actions

   Hey @dinoshauer or @cknv thanks for this hook!!

   Likely, you can just tag latest master as 1.0.5, and then people like @adambrenecki won't have to maintain an alternative repo.

   You could also grant rights to the repo to @adambrenecki 🎉
7. dinoshauer commented on Nov 23, 2017

   

   dinoshauer

   on Nov 23, 2017

   Contributor

   More actions

   Hello everyone, sorry for addressing this so late.
   I don't work at Falcon anymore and I don't have write access to this repo I'm afraid, so there is not much I can do for you.
   I will try and reach out to @cknv through other channels.
   In the meantime, I hope you will find a solution!
8. benjaoming commented on Nov 23, 2017

   

   benjaoming

   on Nov 23, 2017

   Last edited by benjaoming

   More actions

   Shouldn't "FalconSocial" imply that you don't have to work at Falcon to be part of this? :)

   Anyways, thanks @dinoshauer - yes, there are other solutions, just seems that a lot of people have to discover the same thing over and over again.
9. Dunedan commented on Dec 17, 2018

   

   Dunedan

   on Dec 17, 2018

   More actions

   There is an official isort-mirror repository for pre-commit, offering the same functionality and which is also more actively maintained and works with the latest pre-commit version: https://github.com/pre-commit/mirrors-isort/

   👍React with 👍1Reacted by Greg Back