Repository navigation
supervisor: a chain member after the first joins the walk with no client of its own (chain_expect, #348) - #358
Merged
Merged
Conversation
…'s walk (chain_expect), no client of its own (#348) The worker joins it at its add in the head's client: no JACK client is opened for it and closed again by the order line. A worker that refuses chain_expect gets the add and the order line from then on; an add the worker refuses into the chain answers PLACEMENT_INVALID, nothing of it left. Needs omx-clap-core's chain_expect (omx-clap-core#441) rendered.
…hat the chain_expect drop path repeats is made unique
…_expect is used only by a worker that answers it
This was referenced Nov 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a chain's first member, hostd sends the worker
chain_expect <instance> <chain>before the add (omx-clap-core 0.26.0, omx-clap-core#442). The worker then puts the plugin in the head's walk with no JACK client of its own, so the order line that follows changes nothing. Before, it opened a client per member and the order line closed it again: on r1, 23 ms per add for the add and 13 ms for the line.Tests: the fake host answers chain_expect. The daemon tests cover both refusal paths (at the add, and at the order line for a worker without the verb) and the line order the worker gets.