Skip to content

Fix Layers panel UI not updating on selection change and expand/collapsing - #1847

Merged
Keavon merged 2 commits into
masterfrom
fix-layer-select-opacity
Jul 23, 2024
Merged

Keavon merged 2 commits into
masterfrom
fix-layer-select-opacity

Conversation

@TrueDoctor

@TrueDoctor TrueDoctor commented Jul 23, 2024 •

Copy link
Copy Markdown
Member

Also fixes a panic on empty layer.

Closes #1848

@Keavon

Keavon commented Jul 23, 2024 •

Copy link
Copy Markdown
Member

It looks like expanding/collapsing layers in the Layers panel still isn't updating. Right now you have to, for example, rename a layer to get it to send the UI update to show the changed expansion state.

Edit: I fixed it.

@Keavon Keavon changed the title Fix layer properties updete on layer change + fix panic on empty layer Fix Layers panel UI not updating on selection change; fix panic on empty layer Jul 23, 2024
@Keavon
Keavon force-pushed the fix-layer-select-opacity branch from fab7f09 to 791bae8 Compare July 23, 2024 23:38
@Keavon Keavon changed the title Fix Layers panel UI not updating on selection change; fix panic on empty layer Fix Layers panel UI not updating on selection change and expand/collapsing; fix panic on empty layer Jul 23, 2024
@Keavon Keavon changed the title Fix Layers panel UI not updating on selection change and expand/collapsing; fix panic on empty layer Fix Layers panel UI not updating on selection change and expand/collapsing Jul 23, 2024
@Keavon
Keavon enabled auto-merge (squash) July 23, 2024 23:39
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) July 23, 2024 23:40 Inactive
@Keavon
Keavon merged commit ab87486 into master Jul 23, 2024
@Keavon
Keavon deleted the fix-layer-select-opacity branch July 23, 2024 23:44

This branch was previously deployed

1 inactive deployment
graphite-dev (Preview) — 791bae8a Deployed Jul 23, 2024 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Layers panel after layer selection changed, including opacity and group expand/collapse

2 participants