Skip to content

Desktop: Fix resize helper window Z-order and attach to parent console on Windows - #3572

Merged
timon-schelling merged 3 commits into
masterfrom
desktop-win-fix-helper-zorder
Jan 5, 2026
Merged

timon-schelling merged 3 commits into
masterfrom
desktop-win-fix-helper-zorder

Conversation

@timon-schelling

@timon-schelling timon-schelling commented Jan 5, 2026 •

Copy link
Copy Markdown
Member
  • Fix resize issues by allowing Z-order updates (leftovers from minimization fixes I think)
  • Attach to parent console (this lead to icon not being shown before, this was fixed separately in away that is not effected by console state)
  • Workaround for a Windows-specific exception that occurs when app is dropped; closes On Windows desktop, closing the app takes several seconds #3514

@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) January 5, 2026 00:25 Inactive
@Keavon Keavon changed the title Desktop: Fix helper window zorder on Windows Desktop: Fix resize helper window Z-order on Windows Jan 5, 2026
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) January 5, 2026 01:10 Inactive
@timon-schelling timon-schelling changed the title Desktop: Fix resize helper window Z-order on Windows Desktop: Fix resize helper window Z-order and attach to parent console on Windows Jan 5, 2026
@timon-schelling
timon-schelling force-pushed the desktop-win-fix-helper-zorder branch from d374432 to 2fd48ed Compare January 5, 2026 22:23
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) January 5, 2026 22:27 Inactive
@Keavon
Keavon force-pushed the desktop-win-fix-helper-zorder branch from 2fd48ed to 9bf2f90 Compare January 5, 2026 22:27
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) January 5, 2026 22:40 Inactive
@timon-schelling
timon-schelling merged commit bd1f7ee into master Jan 5, 2026
3 checks passed
@timon-schelling
timon-schelling deleted the desktop-win-fix-helper-zorder branch January 5, 2026 23:02

This branch was previously deployed

1 inactive deployment
graphite-dev (Preview) — 9bf2f900 Deployed Jan 5, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On Windows desktop, closing the app takes several seconds

2 participants