Skip to content
This repository was archived by the owner on Nov 8, 2019. It is now read-only.
This repository was archived by the owner on Nov 8, 2019. It is now read-only.

Restructure #21

Open
Open

Description

@geekjuice

We're a bit behind in regards to dependencies and airbnb/javascript went through an entire restructure as well. It may be worth revisiting the structure of this project all together. One thought is to just make a gitbook out of this repository documenting our style guide and create a new repository e.g. HubSpot/eslint-config for our actual configurations.

Activity

  1. timmfin commented on Jun 1, 2016

    @timmfin
    Member

    I'm a bit out of touch here (not fully aware of all the customizations we've added), but I'd at least like to throw out the idea... would it be easier, at least more maintainable for us to not fork the airbnb JS style guide, but rather reference a specific version of it and have a separate list of our changes/customizations/differences?

    I know you've done good work here pushing this forward, and we appreciate that a ton. I'm just seeing if you/we can make a better tradeoff for maintenance effort/bang for the buck.

  2. geekjuice commented on Jun 1, 2016

    @geekjuice
    Author

    💯 I think that's a much better idea! If I understand correctly, that would mean we would only need to need to maintain the differences in our guide. The intent of the fork was to give credit to airbnb, but that may not be necessary anymore since we are mentioned in their documentation.

    As far as the actual configurations, it's fairly easy to diff and compare the rule sets so we can stay up to date with any differences from airbnb's configurations if we need to. Without trying to shamelessly plug, I'm working on something similar in my personal configurations so they are up to date with the airbnb configs and the plugins.

    So with that in mind, I can try to whip up a refactor of this project so that it will be easier to maintain going forward, but also welcome any and all other suggestions so this project can be more useful going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions