Skip to content

fix(cert-agent): apply retry-strategy, failure retries and status-check-interval to certificate issuance and renewal - #511

Open
carlosmonastyrski wants to merge 2 commits into
mainfrom
carlos/pki-397-fix-certificate-agent-retry-and-renewal
Open

carlosmonastyrski wants to merge 2 commits into
mainfrom
carlos/pki-397-fix-certificate-agent-retry-and-renewal

Conversation

@carlosmonastyrski

Copy link
Copy Markdown
Contributor

Description 📣

The certificate agent now honours retry-strategy, max-failure-retries, failure-retry-interval, status-check-interval and renew-before-expiry as documented, retrying failed issuance and renewal within a bounded budget and replacing certificates that expired, were renewed elsewhere, or can never renew.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

  • New or changed commands follow CLI.md, and new commands and flags are recorded in packages/cmd/testdata/command_surface.json
  • Updated AGENTS.md files (if needed)
  • I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

…ck-interval to certificate issuance and renewal
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-511-fix-cert-agent-apply-retry-strategy-failure-retries-and-status

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 18, 2026

Copy link
Copy Markdown

PKI-397

@veria-ai

veria-ai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

All previously flagged issues have been addressed. No open security concerns remain on this pull request.

Fixed/addressed: 1 · PR risk: 0/10

Reviews

Comment thread packages/cmd/agent.go Resolved
@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] This PR appears safe to merge.

Summary

The certificate agent now applies configured retries and check intervals, retries failed work within a budget, and uses certificate dates to plan renewal.

  • Certificate API calls use the agent's configured retry policy.
  • Failed certificate requests retry on a bounded schedule.
  • Renewal checks follow the certificate's actual dates and lifecycle intervals.

All four previous findings are addressed. No new issues were found.

Reviews (2) · Last reviewed commit: "Address PR comments" · Reviewed by Greptile

Comment thread packages/cmd/agent.go Resolved
Comment thread packages/cmd/agent.go Resolved
Comment thread packages/cmd/agent.go Resolved
Comment thread packages/cmd/agent.go Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant