Repository navigation
fix(cert-agent): apply retry-strategy, failure retries and status-check-interval to certificate issuance and renewal - #511
Open
carlosmonastyrski wants to merge 2 commits into
Conversation
…ck-interval to certificate issuance and renewal
|
💬 Discussion in Slack: #pr-review-cli-511-fix-cert-agent-apply-retry-strategy-failure-retries-and-status Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
Contributor
Contributor
[Medium impact] This PR appears safe to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
The certificate agent now honours retry-strategy, max-failure-retries, failure-retry-interval, status-check-interval and renew-before-expiry as documented, retrying failed issuance and renewal within a bounded budget and replacing certificates that expired, were renewed elsewhere, or can never renew.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippetspackages/cmd/testdata/command_surface.json