Skip to content

Added the word AS to the list of function words - #720

Draft
atrsp wants to merge 1 commit into
JabRef:mainfrom
atrsp:issue17523
Draft

atrsp wants to merge 1 commit into
JabRef:mainfrom
atrsp:issue17523

Conversation

@atrsp

@atrsp atrsp commented Nov 4, 2026

Copy link
Copy Markdown

Pull Request Description

Summary

Updated en/setup/citationkeypatterns.md to include the word as in the list of function words ignored during citation key generation.

This change ensures that the user documentation reflects the corrected behavior described in JabRef/jabref#17523.

Steps to test

  1. Open the updated en/setup/citationkeypatterns.md file.
  2. Locate the section listing the function words ignored during citation key generation.
  3. Verify that "as" appears between "around" and "at".
  4. To verify the documented behavior in JabRef:
    • Create a bibliographic entry with the title Economic Systems as Networks.
    • Set the citation key pattern to [shorttitle:lower].
    • Generate the citation key.
    • Verify that the resulting key is economicsystemsnetworks, without the word as.

The behavior was previously verified manually in a local development build of JabRef.

Related issues and pull requests

Closes

Documents JabRef/jabref#17523

AI usage

ChatGPT (OpenAI, GPT-6) was used to assist with understanding the issue.

Checklist

  • [ x ] I reviewed and take ownership of all content in this PR, including any AI-assisted text
  • [ x ] I opened JabRef and followed these instructions myself to confirm they still work (tested on version: local development build — 100.0.0)
  • Any links I added or changed work (N/A if no links were modified)
  • Any images or tables I added display correctly (N/A if none were added)
  • [ x ] I checked spelling/grammar

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Document “as” as a citation-key function word

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Add “as” to the documented list of function words used by title-based citation key patterns.
• Align the documentation with JabRef’s existing behavior; no application code changes.
High-Level Assessment

Adding the missing word directly to the existing list is appropriate because this PR documents existing behavior rather than changing citation-key generation.

Files changed (1) +1 / -1

Documentation (1) +1 / -1
citationkeypatterns.mdAdd “as” to the function-word list +1/-1

Add “as” to the function-word list

• Inserts “as” between “around” and “at” in the documented list of function words relevant to title-based citation key patterns.

en/setup/citationkeypatterns.md

@koppor

koppor commented Nov 4, 2026

Copy link
Copy Markdown
Member

AI generated PR description?

@koppor
koppor marked this pull request as draft November 4, 2026 16:32
@koppor

koppor commented Nov 4, 2026

Copy link
Copy Markdown
Member

PR does NOT fix - JabRef/jabref#17523

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants