Skip to content

feat(jsi): add standalone @nativescript/ios-jsi and @nativescript/android-jsi packages - #76

Open
NathanWalker wants to merge 5 commits into
mainfrom
feat/ios-android-jsi-packages
Open

NathanWalker wants to merge 5 commits into
mainfrom
feat/ios-android-jsi-packages

Conversation

@NathanWalker

@NathanWalker NathanWalker commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Extracts facebook::jsi and rnv8::V8Runtime into two standalone, opt-in packages so the core @nativescript/ios and @nativescript/android runtime binaries remain completely free of JSI bloat:

  • @nativescript/ios-jsi (packages/ios-jsi):
    • Distributed as a Swift Package (Package.swift) wired via nativescript.config.ts (SPMPackages) with zero CocoaPods required.
    • Provides facebook::jsi and rnv8::V8Runtime for iOS.
    • Exposes NativeScriptJSIRuntime(), tns::GetJSIRuntime(), and Objective-C/Swift JSIRuntime.runtime() / JSIRuntime.runtimePointer() keyed per v8::Isolate::GetCurrent() (supporting both main thread and Worker isolates) without depending on internal NativeScript runtime headers.
  • @nativescript/android-jsi (packages/android-jsi):
    • Provides facebook::jsi and rnv8::V8Runtime (libnativescript-jsi.so) for Android.
    • Resolves V8 symbols directly against the loaded libNativeScript.so runtime in the process and keys std::shared_ptr<facebook::jsi::Runtime> per v8::Isolate::GetCurrent().
    • Exposes NativeScriptJSIRuntime(), tns::GetJSIRuntime(), and org.nativescript.jsi.JSIRuntime JNI helpers.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e937bac4-541e-4dc7-93f2-e9dda4da5202

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant