Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
|
While fixing the |
Fixes #25363
Adds a
useJackson3option to thejaxrs-specgenerator. Jackson 2 stays the default.useJackson3option + cliOption,jacksonPackageproperty,JsonDeserializeimport mapping (moved totools.jackson.databindin Jackson 3)spec/pom.mustache:{{jacksonPackage}}groupIds for the JAX-RS providers,jackson-datatype-jsr310only for Jackson 2 (built into databind in Jackson 3), Jackson 3 version 3.1.2 (aligned with the CXF generator)pojo.mustache:Shape.POJOinstead ofShape.OBJECTfor Jackson 3 when additional properties are usedtestUseJackson3inJavaJAXRSSpecServerCodegenTestopenliberty/pom.mustacheunchanged: it only depends onjackson-annotations, which keeps thecom.fasterxml.jackson.coregroupId in Jackson 3.Notes / possible follow-ups:
USE_JACKSON_3and the Jackson package constants are now duplicated across several generators. Happy to consolidate them intoAbstractJavaCodegenin a follow-up PR.Related: #25364 (resteasy client, separate PR).
cc @blaghed
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg @KannaKim