Repository navigation
Conversation
Author
|
@MelleD Could you please review this Java Spring fix for #14866? It uses |
hmooko
marked this pull request as ready for review
October 27, 2026 02:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL-encoded form arrays were generated with
@RequestPart, so Spring MVC could receivenulleven when repeated form fields were supplied. Generate@RequestParamfor non-multipart arrays and retain@RequestPartfor multipart arrays.Add a POST generation regression test for required and optional string arrays, and MockMvc binding tests using the existing sample endpoint. Refresh the affected annotation in 29 existing generated samples without adding endpoints or changing shared sample specifications.
Closes #14866
Validation:
./mvnw -B -pl modules/openapi-generator -am -Dtest=SpringCodegenTest -Dsurefire.failIfNoSpecifiedTests=false test— 487 tests passed../mvnw -B -f samples/server/petstore/springboot/pom.xml test— 5 tests passed, including 2 MockMvc tests.@RequestPart.git diff --checkpassed.Full PR checklist validation also completed successfully:
./mvnw -B clean package— all 8 reactor modules built successfully; 5,678 tests reported, with 14 skipped and no failures or errors../bin/generate-samples.sh ./bin/configs/*.yaml— all 832 sample configurations generated successfully. Some generators logged non-fatal unsupported-feature/example-generation messages; the batch completed successfully and produced no working-tree changes../bin/utils/export_docs_generators.sh— documentation exported for all 172 generators, with no errors or working-tree changes.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.