Skip to content

Use commons 3.2.3-SNAPSHOT to pick up the nullable type fix in the OpenAPI transformer and Guava 33.7.2 against CVE-2026-102554 - #1243

Open
vharseko wants to merge 1 commit into
OpenIdentityPlatform:masterfrom
vharseko:bump-commons-3.2.3-snapshot
Open

vharseko wants to merge 1 commit into
OpenIdentityPlatform:masterfrom
vharseko:bump-commons-3.2.3-snapshot

Conversation

@vharseko

@vharseko vharseko commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Part of OpenIdentityPlatform/OpenIDM#266. Also fixes CVE-2026-102554 in Guava (code scanning alert 1342).

Bumps commons.version from 3.2.2 to 3.2.3-SNAPSHOT.

commons 3.2.3 will carry two changes that matter here:

Guava in OpenDJ: no path to the vulnerable code

  • The main code does not use Guava (two tests do) and has no ObjectInputStream.
  • The JMX RMI connector is the only native deserialization the server exposes. Its connection-wide serial filter (RmiConnector.JMX_OPERATION_SERIAL_FILTER) admits java.lang.*, java.util.*, javax.management.* and a few java.math types and ends with !*, so no com.google.common.* class gets deserialized.

The bump clears the finding; it does not close an exploitable path.

What else changes between 3.2.2 and 3.2.3-SNAPSHOT

When alert 1342 closes

  • trivy-build-*: with the first master build after this PR, provided the 3.2.3-SNAPSHOT with commons#383 is deployed by then. To see it in this PR, its CI has to run after that deploy.
  • trivy-image-*: docker-scan.yml scans the published images every Monday, and 5.2.0 ships Guava 33.4.8-jre. Once that scan reports the CVE, the alert stays open until 5.2.1 is released.

Until commons#383 is merged and the snapshot redeployed, 3.2.3-SNAPSHOT still carries Guava 33.4.8-jre; this PR builds against it either way.

Merge order: commons#382 (merged) → commons#383 → this PR → the OpenICF PR that moves opendj.version to 5.2.1-SNAPSHOT.

Checked locally

help:effective-pom of the root resolves the published commons 3.2.3-SNAPSHOT BOM: api-descriptor 3.2.3-SNAPSHOT. The full build runs in this PR's CI.

…enAPI transformer and Guava 33.7.2 against CVE-2026-102554

commons 3.2.3 brings OpenIdentityPlatform/commons#382: OpenApiTransformer
describes a JSON Schema type array such as ["string", "null"] instead of
failing the whole API description. OpenIDM gets api-descriptor through the
OpenICF BOM, which imports opendj-parent (OpenIdentityPlatform/OpenIDM#266).

It also brings OpenIdentityPlatform/commons#383: Guava 33.4.8-jre
-> 33.7.2-jre, which fixes CVE-2026-102554 (GHSA-xxph-c9ww-hj94). Guava up
to 33.7.1 allocates an array of the size a serialized stream asks for when
it deserializes a CompactHashMap, CompactHashSet or MapMakerInternalMap.
The server ships Guava through http-framework core, but never deserializes
a Guava type: the main code has no ObjectInputStream, and the serial
filter of the JMX RMI connector rejects com.google.common.*.
@vharseko
vharseko force-pushed the bump-commons-3.2.3-snapshot branch from ef6be1f to 8a00d8e Compare October 29, 2026 13:23
@vharseko
vharseko requested a review from maximthomas October 29, 2026 13:23
@vharseko vharseko changed the title Use commons 3.2.3-SNAPSHOT to pick up the nullable type fix in the OpenAPI transformer Use commons 3.2.3-SNAPSHOT to pick up the nullable type fix in the OpenAPI transformer and Guava 33.7.2 against CVE-2026-102554 Oct 29, 2026
@vharseko vharseko added the security Security fixes / CodeQL code-scanning alerts label Oct 29, 2026
vharseko added a commit to OpenIdentityPlatform/commons that referenced this pull request Oct 29, 2026
Bumps Guava in the `parent` POM from 33.4.8-jre to 33.7.2-jre, so every
downstream consumer of the BOM picks up the fix without per-project
overrides.

### CVE-2026-102554 / GHSA-xxph-c9ww-hj94 (high, CVSS 5.9)

From 4.0 through 33.7.1, Guava allocates an array of the size a
serialized stream asks for when it deserializes a `CompactHashMap`,
`CompactHashSet` or `MapMakerInternalMap`, so a crafted stream exhausts
the heap (CWE-770). 33.7.2 fixes it (google/guava@a0d0c36432).

Trivy reports it in the OpenDJ images
(`lib/com.google.guava.guava.jar`), which get Guava through
`http-framework/core`. OpenIdentityPlatform/OpenDJ#1243 moves OpenDJ to
3.2.3-SNAPSHOT.

### What else changes between 33.4.8 and 33.7.2

- The runtime dependencies are the same (`failureaccess` 1.0.3, the
empty `listenablefuture`, `jspecify`, `error_prone_annotations`,
`j2objc-annotations`), so the exclusions stay as they are.
- Six members become deprecated: the `CacheBuilder` methods that take a
`TimeUnit` (`expireAfterAccess`, `expireAfterWrite`,
`refreshAfterWrite`; 33.6.0),
`ImmutableSortedMap.pollFirstEntry`/`pollLastEntry` and
`Graphs.transitiveClosure(Graph)`. The only one commons calls is
`expireAfterAccess(60, TimeUnit.SECONDS)` in `geo`'s `Client`; it now
passes `Duration.ofSeconds(60)` (available since Guava 25), so the build
gets no new deprecation warning and CodeQL no new
`java/deprecated-call`.
- 33.7.0 moved `module-info.class` to the jar root, and 33.7.1 removed
the `Multi-Release` manifest line that came with it.

### Verification

`clean verify` of every module that uses Guava, together with the
modules they depend on (`-pl
bloomfilter/core,bloomfilter/monitoring,commons/audit/handler-splunk,commons/auth-filters/authn-filter/jaspi-runtime,commons/geo,commons/http-framework/core,commons/rest/api-descriptor,commons/rest/json-resource,commons/rest/json-resource-http,commons/selfservice/custom-stage,commons/selfservice/json,guice/core
-am`), on JDK 11.0.32 and JDK 27:

- 8516 tests, 0 failures, 0 errors, 0 skipped on each JDK
(`bloomfilter/core` 4877, `http-framework/core` 1059, `json-resource`
529, `util` 451, …).
- `dependency:list`: every module with Guava on its classpath resolves
`com.google.guava:guava:33.7.2-jre`.
- The compiler reports no deprecation for Guava members in main code.
The two that remain are older, in a test (`Charsets.UTF_8` and
`Files.toString` in `api-descriptor`'s `ExamplesTest`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dependencies Pull requests that update a dependency file security Security fixes / CodeQL code-scanning alerts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenApiTransformer fails on a JSON Schema type array such as ["string", "null"]

2 participants