Repository navigation
Use commons 3.2.3-SNAPSHOT to pick up the nullable type fix in the OpenAPI transformer and Guava 33.7.2 against CVE-2026-102554 - #1243
Open
vharseko wants to merge 1 commit into
Conversation
…enAPI transformer and Guava 33.7.2 against CVE-2026-102554 commons 3.2.3 brings OpenIdentityPlatform/commons#382: OpenApiTransformer describes a JSON Schema type array such as ["string", "null"] instead of failing the whole API description. OpenIDM gets api-descriptor through the OpenICF BOM, which imports opendj-parent (OpenIdentityPlatform/OpenIDM#266). It also brings OpenIdentityPlatform/commons#383: Guava 33.4.8-jre -> 33.7.2-jre, which fixes CVE-2026-102554 (GHSA-xxph-c9ww-hj94). Guava up to 33.7.1 allocates an array of the size a serialized stream asks for when it deserializes a CompactHashMap, CompactHashSet or MapMakerInternalMap. The server ships Guava through http-framework core, but never deserializes a Guava type: the main code has no ObjectInputStream, and the serial filter of the JMX RMI connector rejects com.google.common.*.
vharseko
force-pushed
the
bump-commons-3.2.3-snapshot
branch
from
October 29, 2026 13:23
ef6be1f to
8a00d8e
Compare
maximthomas
approved these changes
Oct 29, 2026
vharseko
added a commit
to OpenIdentityPlatform/commons
that referenced
this pull request
Oct 29, 2026
Bumps Guava in the `parent` POM from 33.4.8-jre to 33.7.2-jre, so every downstream consumer of the BOM picks up the fix without per-project overrides. ### CVE-2026-102554 / GHSA-xxph-c9ww-hj94 (high, CVSS 5.9) From 4.0 through 33.7.1, Guava allocates an array of the size a serialized stream asks for when it deserializes a `CompactHashMap`, `CompactHashSet` or `MapMakerInternalMap`, so a crafted stream exhausts the heap (CWE-770). 33.7.2 fixes it (google/guava@a0d0c36432). Trivy reports it in the OpenDJ images (`lib/com.google.guava.guava.jar`), which get Guava through `http-framework/core`. OpenIdentityPlatform/OpenDJ#1243 moves OpenDJ to 3.2.3-SNAPSHOT. ### What else changes between 33.4.8 and 33.7.2 - The runtime dependencies are the same (`failureaccess` 1.0.3, the empty `listenablefuture`, `jspecify`, `error_prone_annotations`, `j2objc-annotations`), so the exclusions stay as they are. - Six members become deprecated: the `CacheBuilder` methods that take a `TimeUnit` (`expireAfterAccess`, `expireAfterWrite`, `refreshAfterWrite`; 33.6.0), `ImmutableSortedMap.pollFirstEntry`/`pollLastEntry` and `Graphs.transitiveClosure(Graph)`. The only one commons calls is `expireAfterAccess(60, TimeUnit.SECONDS)` in `geo`'s `Client`; it now passes `Duration.ofSeconds(60)` (available since Guava 25), so the build gets no new deprecation warning and CodeQL no new `java/deprecated-call`. - 33.7.0 moved `module-info.class` to the jar root, and 33.7.1 removed the `Multi-Release` manifest line that came with it. ### Verification `clean verify` of every module that uses Guava, together with the modules they depend on (`-pl bloomfilter/core,bloomfilter/monitoring,commons/audit/handler-splunk,commons/auth-filters/authn-filter/jaspi-runtime,commons/geo,commons/http-framework/core,commons/rest/api-descriptor,commons/rest/json-resource,commons/rest/json-resource-http,commons/selfservice/custom-stage,commons/selfservice/json,guice/core -am`), on JDK 11.0.32 and JDK 27: - 8516 tests, 0 failures, 0 errors, 0 skipped on each JDK (`bloomfilter/core` 4877, `http-framework/core` 1059, `json-resource` 529, `util` 451, …). - `dependency:list`: every module with Guava on its classpath resolves `com.google.guava:guava:33.7.2-jre`. - The compiler reports no deprecation for Guava members in main code. The two that remain are older, in a test (`Charsets.UTF_8` and `Files.toString` in `api-descriptor`'s `ExamplesTest`).
Open
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OpenIdentityPlatform/OpenIDM#266. Also fixes CVE-2026-102554 in Guava (code scanning alert 1342).
Bumps
commons.versionfrom 3.2.2 to 3.2.3-SNAPSHOT.commons 3.2.3 will carry two changes that matter here:
OpenApiTransformerdescribes a JSON Schema type array such as["string", "null"]instead of failing the whole API description with/type: Expecting a java.lang.String. OpenDJ does not call the transformer itself. The bump matters for OpenIDM: it imports the OpenICF BOM, which importsopendj-parent, and that is where OpenIDM'sapi-descriptorversion comes from. OpenIDM drops the API description of a managed object as soon as one of its attributes is marked as nullable (Unable to define an attribute as "nullable" OpenIDM#266).CompactHashMap,CompactHashSetorMapMakerInternalMap, so a crafted stream exhausts the heap. The server ships Guava throughhttp-framework/coreaslib/com.google.guava.guava.jar, and Trivy reports it in thetrivy-build-alpineandtrivy-build-defaultscans of the images built bybuild.yml.Guava in OpenDJ: no path to the vulnerable code
ObjectInputStream.RmiConnector.JMX_OPERATION_SERIAL_FILTER) admitsjava.lang.*,java.util.*,javax.management.*and a fewjava.mathtypes and ends with!*, so nocom.google.common.*class gets deserialized.The bump clears the finding; it does not close an exploitable path.
What else changes between 3.2.2 and 3.2.3-SNAPSHOT
failureaccess1.0.3, the emptylistenablefuture,jspecify,error_prone_annotations,j2objc-annotations).CacheBuildermethods that take aTimeUnit. OpenDJ does not call them: its caches are Caffeine.InjectorHolder([#376] InjectorHolder: build the root injector on first use and report a failed build to each caller with its cause commons#377), which OpenDJ does not use; the rest is CI workflows.When alert 1342 closes
trivy-build-*: with the first master build after this PR, provided the 3.2.3-SNAPSHOT with commons#383 is deployed by then. To see it in this PR, its CI has to run after that deploy.trivy-image-*:docker-scan.ymlscans the published images every Monday, and 5.2.0 ships Guava 33.4.8-jre. Once that scan reports the CVE, the alert stays open until 5.2.1 is released.Until commons#383 is merged and the snapshot redeployed, 3.2.3-SNAPSHOT still carries Guava 33.4.8-jre; this PR builds against it either way.
Merge order: commons#382 (merged) → commons#383 → this PR → the OpenICF PR that moves
opendj.versionto 5.2.1-SNAPSHOT.Checked locally
help:effective-pomof the root resolves the published commons 3.2.3-SNAPSHOT BOM:api-descriptor3.2.3-SNAPSHOT. The full build runs in this PR's CI.