Source code viewer has tiny height

@Zren

This was only thing I caught when testing #129 but it wasn't enough to prevent me from merging and deploying. ~~It happens when not logged in.~~

Maybe it has nothing to do with being logged in. This script looks the same to me logged in or not. But some scripts don't have this problem for whatever reason.

Okay I got it. It's a Chrome issue (I tested logged out using Chrome and logged in using Firefox).

html, body { min-height: 100vh; } maybe?

I used:

body > .container-fluid {
  min-height: calc(100vh - 50px - 20px - 50px);
}

and

#editor {
  position: relative;
  min-height: 200px;
  height: calc(100vh - 190px);
}

On that page. I forgot that some browsers need that set to make webapps scaled to the viewport. Though it works fine on my Chrome install (dev branch).

100vh = 100% viewport height.

Did this get fixed? In Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.114 Safari/537.36 (Chromium) it appears to be doing okay with last assumed production deployment of a128bc8 ~~Retested: Isn't working in Chromium.~~ Retested again and now it is working as expected. Weird boog.

Did this get fixed?

Not for me. This page: https://openuserjs.org/scripts/joesimmons/httpuserscripts.orgusers23652/YouTube_Auto_Buffer_Auto_HD/source

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.114 Safari/537.36

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.114 Safari/537.36

hmm your Chrome value appears to be behind... usually the UA's are nearly identical.

Confirmed on:

Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36
Squeeky clean install (first time on that machine)

P.S. That was very trying to get Chrome to install ... I had to locate a url to manually download the installer since zero browsers would download and install it. Noticed you crossed out "not logged in" too.. so I checked logged in too... Are you using a distro package for Chrome?... perhaps it's out of date.

Normalize viewport height to be a minimum off 100vh. Possibly fix Ope…

Merge pull request #160 from Zren/uifix

Still happening to me. It shouldn't matter if my version of Chrome isn't the exact latest.

It shouldn't matter

Well unfortunately it does... on Wednesday I asked a friend of mine to try the site on his Android and tables were quite messed up in md. Keep your version though maybe we'll figure out a hidden issue.

A-ha! Opera/9.80 (X11; Linux x86_64) Presto/2.12.388 Version/12.16 exhibits this behavior currently (does not in Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36 OPR/22.0.1471.70) ... something to test on finally. ;) ... also does it on the register/login page.

@sizzlemctwizzle

It seems like the issue is that calc doesn't exist.... e.g. height: calc(100vh - 190px); does nothing... tried converting to all px and still nothing... removed the calc and put in a static value and it resized to that value... checking browser compatibility... CSS3 implemented... a table of compatibility. EDIT: vh measurement unit doesn't do anything too... a table of compatibility so that is probably CSS3 too.

@sizzlemctwizzle

Can you try prefixing with these on your Chrome at ./views/pages/scriptViewSourcePage.html and perhaps just single rules to isolate if any work:

    #editor {
      position: relative;
      min-height: 200px;
      height: -moz-calc(100vh - 190px);
      height: -webkit-calc(100vh - 190px);
      height: -o-calc(100vh - 190px);
      height: calc(100vh - 190px);
    }

This doesn't fix it in Opera Presto (older version) though... just no support for this CSS3 function in older browsers I think. A bug in the latest Chrome/Chromium perhaps.

Added similar rules to oujs - Meta View

NEW. openuserjs.org’s CODE VIEW HEIGHT FIX (for opera 12 etc.)

Use jQuery listener to resize Source Code on the fly for older browsers

Closing from #503 and #505 ... reopen if necessary.

@Martii

Thanks very much, @Martii !
I unfortunately hadn’t notice your fix earlier than yesterday (jesus2099/konami-command@37c5bd2).
That’s working great !

Refix source code viewer has tiny height

More followup for source code has tiny height

NEW. openuserjs.org’s CODE VIEW HEIGHT FIX (for opera 12 etc.)

Navigation Menu

Repository navigation

Source code viewer has tiny height #136

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Source code viewer has tiny height #136

Description

Activity

sizzlemctwizzle commented on Jun 11, 2014

sizzlemctwizzle commented on Jun 11, 2014

Zren commented on Jun 11, 2014

Martii commented on Jun 12, 2014

sizzlemctwizzle commented on Jun 13, 2014

Martii commented on Jun 13, 2014

Martii commented on Jun 14, 2014

sizzlemctwizzle commented on Jun 14, 2014

Martii commented on Jun 14, 2014

Martii commented on Jul 9, 2014

Martii commented on Jul 9, 2014

Martii commented on Jan 11, 2015

jesus2099 commented on Jan 5, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions