You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Source Code could be view only until selected #169
On the normal description of a script, we get this:
...but going to the source code view, that header info is missing. This makes it hard to navigate.
In addition to that, source code can be edited (I am assuming so that you could edit and submit as a fork) but I'm sure most of the time, people will be viewing more than editing. Perhaps that should be another issue?
Even if you are just viewing, does it make a difference that you can also
edit it? If you long out, you can see it in read-only mode btw. If it makes
a difference we could always add checkbox/button to toggle editing off/on.
On Jun 14, 2014 7:56 PM, "Ryan Chatham" notifications@github.com wrote:
On the normal description of a script, we get this:
...but going to the source code view, that header info is missing. This
makes it hard to navigate.
In addition to that, source code can be edited (I am assuming so that you
could edit and submit as a fork) but I'm sure most of the time, people will
be viewing more than editing. Perhaps that should be another issue?
—
Reply to this email directly or view it on GitHub #169.
Even if you are just viewing, does it make a difference that you can also edit it?
To me, yes; I was viewing a script earlier, thought I tabbed over to another program, started typing and didn't notice that I was still focused on the source. When I got back to viewing the source (after I had properly focused on the other program and did my thing), I didn't know I typed anything so it was a bit confusing to see some random unrelated gibberish that I typed earlier.
Obviously it was my issue, but I don't see why it needs to be in edit mode by default; many source control sites aren't in edit mode by default (Github and Bitbucket being the easiest to reference). When viewing, I would prefer the source to be read only, so that I don't muck it up by accident.
Whether that is done by an "edit" checkbox, or a "Fork" button that brings you to a new-script-like editing page doesn't really matter, although the latter seems to follow the same routine that GH forking would do (and would be my preferred method).
I don't see why it needs to be in edit mode by default
It is helpful for finding an issue with ACE right now in #148 and JavaScript enabled/disabled tests and where it's hosted I think.
I think the main question I have would be:
Are there any accidental gestures that could cause accidental repercussions on that page?
Not paying attention to what program one is on usually shouldn't be an issue but as I inferred from your comment... user error happens.
does it make a difference that you can also edit it?
I do like the "ready to go" approach but haven't considered the above question fully.
@cletusc
Reopening this since there is some chatter here but I'll strike out the duplicate part and change the subject from:
Source code page is missing the script info/navigation
Woops, looks like this is a duplicate
Only a duplicate if the main issue is such... you had one bug report (the dupe) and one change in behavior (enhancement). Subsequent comments on that other issue (bug report only) started to stray too... more "related" too. :)
Has anyone actually tried this recently on a portable phone? (touch screen)
I can't see any gestures that would conflict with having it ready to edit. I have to long tap to kick in my on-screen keyboard and click somewhere off of the text-area box to close the keyboard.
Activity
cletusc commentedon Jun 15, 2014
Woops, looks like this is a duplicate of #150.
sizzlemctwizzle commentedon Jun 15, 2014
Even if you are just viewing, does it make a difference that you can also
edit it? If you long out, you can see it in read-only mode btw. If it makes
a difference we could always add checkbox/button to toggle editing off/on.
On Jun 14, 2014 7:56 PM, "Ryan Chatham" notifications@github.com wrote:
cletusc commentedon Jun 15, 2014
To me, yes; I was viewing a script earlier, thought I tabbed over to another program, started typing and didn't notice that I was still focused on the source. When I got back to viewing the source (after I had properly focused on the other program and did my thing), I didn't know I typed anything so it was a bit confusing to see some random unrelated gibberish that I typed earlier.
Obviously it was my issue, but I don't see why it needs to be in edit mode by default; many source control sites aren't in edit mode by default (Github and Bitbucket being the easiest to reference). When viewing, I would prefer the source to be read only, so that I don't muck it up by accident.
Whether that is done by an "edit" checkbox, or a "Fork" button that brings you to a new-script-like editing page doesn't really matter, although the latter seems to follow the same routine that GH forking would do (and would be my preferred method).
[-]Source code page is missing the script info/navigation[/-][+]Source code could be view only until selected[/+]Martii commentedon Jun 15, 2014
It is helpful for finding an issue with ACE right now in #148 and JavaScript enabled/disabled tests and where it's hosted I think.
I think the main question I have would be:
Not paying attention to what program one is on usually shouldn't be an issue but as I inferred from your comment... user error happens.
I do like the "ready to go" approach but haven't considered the above question fully.
@cletusc
Reopening this since there is some chatter here but I'll strike out the duplicate part and change the subject from:
Only a duplicate if the main issue is such... you had one bug report (the dupe) and one change in behavior (enhancement). Subsequent comments on that other issue (bug report only) started to stray too... more "related" too. :)
[-]Source code could be view only until selected[/-][+]Source Code could be view only until selected[/+]Martii commentedon Oct 23, 2014
Has anyone actually tried this recently on a portable phone? (touch screen)
I can't see any gestures that would conflict with having it ready to edit. I have to long tap to kick in my on-screen keyboard and click somewhere off of the text-area box to close the keyboard.
Move and duplicate Raw Source button to Source Code pages