Skip to content

Source Code could be view only until selected #169

Closed

Description

@cletusc

On the normal description of a script, we get this:

...but going to the source code view, that header info is missing. This makes it hard to navigate.

In addition to that, source code can be edited (I am assuming so that you could edit and submit as a fork) but I'm sure most of the time, people will be viewing more than editing. Perhaps that should be another issue?

Activity

  1. cletusc commented on Jun 15, 2014

    @cletusc
    ContributorAuthor

    Woops, looks like this is a duplicate of #150.

  2. sizzlemctwizzle commented on Jun 15, 2014

    @sizzlemctwizzle
    Member

    Even if you are just viewing, does it make a difference that you can also
    edit it? If you long out, you can see it in read-only mode btw. If it makes
    a difference we could always add checkbox/button to toggle editing off/on.
    On Jun 14, 2014 7:56 PM, "Ryan Chatham" notifications@github.com wrote:

    On the normal description of a script, we get this:

    https://github.com/proxy/camo.githubusercontent.com/dd5ee22bde18f9eb2606d8b6d5c48595779e36c5/687474703a2f2f7075752e73682f39745467662e706e67

    ...but going to the source code view, that header info is missing. This
    makes it hard to navigate.

    In addition to that, source code can be edited (I am assuming so that you
    could edit and submit as a fork) but I'm sure most of the time, people will
    be viewing more than editing. Perhaps that should be another issue?

    —
    Reply to this email directly or view it on GitHub
    #169.

  3. cletusc commented on Jun 15, 2014

    @cletusc
    ContributorAuthor

    Even if you are just viewing, does it make a difference that you can also edit it?

    To me, yes; I was viewing a script earlier, thought I tabbed over to another program, started typing and didn't notice that I was still focused on the source. When I got back to viewing the source (after I had properly focused on the other program and did my thing), I didn't know I typed anything so it was a bit confusing to see some random unrelated gibberish that I typed earlier.

    Obviously it was my issue, but I don't see why it needs to be in edit mode by default; many source control sites aren't in edit mode by default (Github and Bitbucket being the easiest to reference). When viewing, I would prefer the source to be read only, so that I don't muck it up by accident.

    Whether that is done by an "edit" checkbox, or a "Fork" button that brings you to a new-script-like editing page doesn't really matter, although the latter seems to follow the same routine that GH forking would do (and would be my preferred method).

  4. changed the title [-]Source code page is missing the script info/navigation[/-] [+]Source code could be view only until selected[/+] on Jun 15, 2014
  5. Martii commented on Jun 15, 2014

    @Martii
    Member

    I don't see why it needs to be in edit mode by default

    It is helpful for finding an issue with ACE right now in #148 and JavaScript enabled/disabled tests and where it's hosted I think.

    I think the main question I have would be:

    • Are there any accidental gestures that could cause accidental repercussions on that page?

    Not paying attention to what program one is on usually shouldn't be an issue but as I inferred from your comment... user error happens.

    does it make a difference that you can also edit it?

    I do like the "ready to go" approach but haven't considered the above question fully.

    @cletusc
    Reopening this since there is some chatter here but I'll strike out the duplicate part and change the subject from:

    Source code page is missing the script info/navigation


    Woops, looks like this is a duplicate

    Only a duplicate if the main issue is such... you had one bug report (the dupe) and one change in behavior (enhancement). Subsequent comments on that other issue (bug report only) started to stray too... more "related" too. :)

  6. reopened this on Jun 15, 2014
  7. changed the title [-]Source code could be view only until selected[/-] [+]Source Code could be view only until selected[/+] on Jun 16, 2014
  8. Martii commented on Oct 23, 2014

    @Martii
    Member

    Has anyone actually tried this recently on a portable phone? (touch screen)

    I can't see any gestures that would conflict with having it ready to edit. I have to long tap to kick in my on-screen keyboard and click somewhere off of the text-area box to close the keyboard.

  9. added
    mightfixEhh maybe... convince us all...
    and removed
    questionA question has been encountered by anyone and has remained unanswered until cleared.
    on Jan 11, 2015
  10. added a commit that references this issue on Apr 30, 2015
    624873d
  11. self-assigned this
    on Apr 30, 2015
  12. removed
    mightfixEhh maybe... convince us all...
    on Apr 30, 2015
  13. removed their assignment
    on Apr 30, 2015
  14. locked as resolved and limited conversation to collaborators on Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSomething we do have implemented already but needs improvement upon to the best of knowledge.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions