Skip to content

Fix not being able to highlight text in compare config tab - #2190

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-config-select
Jun 26, 2026
Merged

LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-config-select

Conversation

@vaisest

@vaisest vaisest commented Jun 13, 2026 •

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Fixes compare tab config subtab controls clearing user selection on every frame.

Also fixes a crash when distance config has too many digits that I accidentally found Reverted because @LocalIdentity had a fix implemented elsewhere

Steps taken to verify a working solution:

  • Tested with my own build while using pob

Link to a build that showcases this PR:

https://pobb.in/x5Djmznj897s
https://pobb.in/CZfC5voLQXWp

Before screenshot:

Path.space.of.space.Building-PoE2_2026-06-13_11-45-15.mp4

After screenshot:

Path.space.of.space.Building-PoE2_2026-06-13_11-49-05.mp4

@vaisest
vaisest force-pushed the fix-config-select branch from e8d107e to 0a9265e Compare June 13, 2026 11:53
@vaisest vaisest added pob1 Should also be merged into PoB1 Repo bug: behaviour Behavioural differences labels Jun 20, 2026
Couldn't type a `-` character into the box without it being wiped

@LocalIdentity LocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it not allowing you to type in - anymore with the focus part

@LocalIdentity
LocalIdentity merged commit 6295cc2 into PathOfBuildingCommunity:dev Jun 26, 2026
5 checks passed
@LocalIdentity LocalIdentity changed the title Fix compare config tab controls not supporting selections Fix not being able to highlight text in compare config tab Jun 26, 2026
LocalIdentity pushed a commit to PathOfBuildingCommunity/PathOfBuilding that referenced this pull request Jul 20, 2026
…9905)

Co-authored-by: vaisest <vaisest@users.noreply.github.com>
@vaisest
vaisest deleted the fix-config-select branch August 28, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioural differences pob1 Should also be merged into PoB1 Repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants