Skip to content

Fix matching socket quality in item comparisons - #10396

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/item-compare-socket-quality
Oct 29, 2026
Merged

LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/item-compare-socket-quality

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Fixes #10362

Description of the problem being solved:

When previewing an item with different socket colors, PoB recalculated the item’s stats but did not recalculate which gems matched its sockets. It continued using the gem-quality bonuses from the currently equipped item. This made the tooltip disagree with the result after actually equipping the item.

In the example build, Corpse Fletch showed ~69.6k additional Combined DPS in the tooltip but gave ~75.2k after being equipped.

This is because the comparison calculation used the cached socket match state from the equipped item. It now determines matching socket quality from the item used by the calculation, including socket order, and carries that value into the gem quality breakdown.

Steps taken to verify a working solution:

  • Loaded the affected build and confirmed Corpse Fletch previews and equips at 564,350.7823 Combined DPS, a gain of 75,217.7758 from the 489,133.0065 base.
  • Ran TestGemSocketQuality_spec.lua: 14 successes, 0 failures.
  • Ran the full test suite: 585 successes, 0 failures.

Link to a build that showcases this PR:

https://pob.codes/b/gxbNWwV4BXK

Before screenshot:

image

After screenshot:

image

@LocalIdentity LocalIdentity added bug: behaviour Behavioral differences bug: calculation Numerical differences and removed bug: behaviour Behavioral differences labels Oct 29, 2026
@LocalIdentity
LocalIdentity merged commit e6489fb into PathOfBuildingCommunity:dev Oct 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item removal tooltip retains matching-socket gem quality

2 participants