Skip to content

feat: Add types to build.py and refactor helper methods - #1707

Merged
Naramsim merged 5 commits into
masterfrom
k8s-no-arm
Nov 2, 2026
Merged

Naramsim merged 5 commits into
masterfrom
k8s-no-arm

Conversation

@Naramsim

@Naramsim Naramsim commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

By @FallenDeity

Part of #1391

  • Add type hints to build.py, along with a bit of a refactor move the helpers and constants to utils
  • Dropped some redundant queries and increased batch limit
  • Made ruff and ty checks mandatory now since we have coverage for type hints everywhere except tests (which is ignored in the config tomls)
  • updated runners to arm64 runners for performance/efficiency (noticed some decent performance improvements)

build itself is about 20%ish faster now overall gains should be about 30% with everything

@Naramsim
Naramsim marked this pull request as ready for review November 2, 2026 06:38
@Naramsim
Naramsim merged commit e5b79b2 into master Nov 2, 2026
32 checks passed
@Naramsim
Naramsim deleted the k8s-no-arm branch November 2, 2026 06:41
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

2 similar comments
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants