Skip to content

Fix CI action pinning - #62

Open
emmatyping wants to merge 2 commits into
3.x-rust-in-cpythonfrom
fix-CI-lints
Open

emmatyping wants to merge 2 commits into
3.x-rust-in-cpythonfrom
fix-CI-lints

Conversation

@emmatyping

Copy link
Copy Markdown

No description provided.

@emmatyping
emmatyping requested a review from Eclips4 November 16, 2026 19:46
@emmatyping
emmatyping removed the request for review from JacobCoffee November 16, 2026 19:46
using: composite
steps:
- uses: dtolnay/rust-toolchain@f133eefe930d61f0d9371efd474daf0125ed3dd1 # 1.95.0
- uses: dtolnay/rust-toolchain@1961bfc0c4a8bf07e0a0c98e1e2459c642ea70a0 # 1.95.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: dtolnay/rust-toolchain@1961bfc0c4a8bf07e0a0c98e1e2459c642ea70a0 # 1.95.0
- uses: dtolnay/rust-toolchain@1.95.0

And update actions.lock:

gh extension install github/gh-actions-lock
gh actions-lock

https://hugovk.dev/blog/2026/lock-github-actions/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I did originally use 1.95.0 here, but when I did, zizimor complained this was unpinned. Is there something special I'm meant to do that I'm missing?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, this is a composite action, we don't use those anywhere else in the upstream CI.

zizmor doesn't yet support lockfiles here, so we'll need to keep the hash pin for now.

Comment thread .github/workflows/cargo.yml Resolved

@hugovk hugovk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants