Repository navigation
Second round of correctness fixes on multiple backends - #1335
Merged
Merged
Conversation
Collaborator
|
sure, but might have to wait until monday |
Contributor
|
I think it's great if we can share knowledge, absolutely no objections from me! |
Member
Author
No worries, let me know when it's done, many of these things we can still backport to |
LastExceed
requested changes
Aug 24, 2026
LastExceed
left a comment
Collaborator
There was a problem hiding this comment.
Static review only so far, haven't tested anything yet. Also can't speak on the changes to non-windows backends, as I am not familiar with them
Collaborator
|
ran a couple examples on hardware via ASIO and WASAPI, no problems to report |
roderickvd
force-pushed
the
fix/backend-robustness-round2
branch
2 times, most recently
from
September 1, 2026 16:49
f69d62f to
ca13908
Compare
LastExceed
reviewed
Sep 1, 2026
roderickvd
force-pushed
the
fix/backend-robustness-round2
branch
from
September 7, 2026 19:37
a49ad9d to
5b6146f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the result from a second pass comparing cpal against CamillaDSP's backends for correctness and robustness
gaps (first one landed in 0.18.0). Their backends moved on since (
next5), so I went through it again.In full transparency of licensing: CamillaDSP is MPL-2.0, cpal is Apache 2.0. That should be OK: MPL's copyleft covers licensed source files but not ideas or bugs found while reading them. Nothing was copied, rather, every fix was reimplemented against cpal's conventions. @HEnquist let me know if you have any objections.
@LastExceed would you verify the ASIO and WASAPI changes? You'll note that in WASAPI I made some small changes to pave the way for exclusive mode later.