Skip to content

Feature Request: Add Taylor Window implementation #196

Open

Description

@parinya-ao

Summary

This is a feature request to add support for the Taylor window

Expected Result

A function or method is available to generate a Taylor window, similar to scipy.signal.windows.taylor() or MATLAB's taylorwin()

Actual Result

The Taylor window is currently not implemented in this crate. Attempting to find it results in no available function

Activity

  1. PanieriLorenzo commented on Jan 20, 2026

    @PanieriLorenzo
    Collaborator

    I'd like to implement this, however we should probably support other more common window functions. We currently only have Hanning and Rectangle.

  2. PanieriLorenzo commented on Feb 21, 2026

    @PanieriLorenzo
    Collaborator

    So @roderickvd and I had a brief convo on the Rust-audio Discord, and we floated the idea of using the windowfunctions crate internally.

    The problem is that windowfunctions requires num_traits::Float. It would be a bit strange that we rely on num_traits only when it comes to dasp_window, but round-trip to f32 or f64 in all other places where we need floating point functions like cos or sqrt in the crate. We could still do this, but I also opened an issue about relying on num-traits instead of round-tripping in #198, which we could implement first.

    We can also just reference their implementation but roll our own if we want to avoid dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions