You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Feature Request: Add Taylor Window implementation #196
So @roderickvd and I had a brief convo on the Rust-audio Discord, and we floated the idea of using the windowfunctions crate internally.
The problem is that windowfunctions requires num_traits::Float. It would be a bit strange that we rely on num_traits only when it comes to dasp_window, but round-trip to f32 or f64 in all other places where we need floating point functions like cos or sqrt in the crate. We could still do this, but I also opened an issue about relying on num-traits instead of round-tripping in #198, which we could implement first.
We can also just reference their implementation but roll our own if we want to avoid dependencies.
Activity
PanieriLorenzo commentedon Jan 20, 2026
I'd like to implement this, however we should probably support other more common window functions. We currently only have
HanningandRectangle.PanieriLorenzo commentedon Feb 21, 2026
So @roderickvd and I had a brief convo on the Rust-audio Discord, and we floated the idea of using the windowfunctions crate internally.
The problem is that windowfunctions requires
num_traits::Float. It would be a bit strange that we rely on num_traits only when it comes to dasp_window, but round-trip to f32 or f64 in all other places where we need floating point functions likecosorsqrtin the crate. We could still do this, but I also opened an issue about relying on num-traits instead of round-tripping in #198, which we could implement first.We can also just reference their implementation but roll our own if we want to avoid dependencies.