Repository navigation
Fix Go patch delivery, audits, and reinstalls - #1698
Draft
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Draft
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Conversation
Verify the native vendor tree selected by Go before attesting patches. Account for workspaces, GOFLAGS, selected packages, embedded assets, and dependency-only fixes. Forward consumer synchronization warnings through nested agent get operations. Preserve upstream checksum lines with local patch artifacts and restore them on rollback after tidy. Refuse checksum conflicts without removing an active replacement or its copy, including orphan reconciliation. Replace empty production Go canaries with pgx/v5 execution proofs for hosted, vendored, and agent delivery, fresh caches, cold agent failure and recovery, and rollback. Add real Go regressions for native drift and the lifecycle failures reproduced by the smoke repository. Assisted-by: Codex:GPT-6
Reuse verified project-local agent copies after clearing the Go module cache. Refuse corrupted copies without an upstream rebuild source. Exercise get, scan, dependency maintenance, repeated native vendoring, and workspace synchronization with the patched pgx decoder. Assisted-by: Codex:gpt-6-astra
Collaborator
Author
|
Burn-down agent: draft CI is green on Question for a human: once depscan#28901 is deployed and the pgx Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pgx/v5 smoke test exposed local Go patches that could be attested while Go built vulnerable bytes from native
vendor/, a missing warning in agentget, and rollback that stopped building aftergo mod tidyremoved upstream checksums. Reapplying an intact agent patch after deleting the module cache also failed withpackage_not_installed. The production Go canaries passed without proving delivery.Changes
apply --check/vendor --check. Cover workspace markers, quoted and double-hyphen GOFLAGS, unused replacements, package selection, ignored files, embedded assets, and dependency-only patches.github.com/jackc/pgx/v5@v5.7.0patchd8941a4c-4bcd-4756-b0aa-239ec9c81b0f: require a delivery event and reject the malformed decoder input without a panic. Exercise get/scan, fresh caches, cache removal, same-versiongo get,go mod download/tidy/verify, consumer tests, repeated native vendoring, offline rollback after tidy, and explicit cold-cache agent failure followed by recovery. Hosted/vendored workspace tests also exercisego work syncandgo work vendorwhen supported.The cold-cache false
appliedresult from the older smoke-test revision was already fixed on current main; this PR adds a live regression guard for the corrected failure behavior.Validation
5c4066702(32 settled checks). Heavy draft-gated jobs were validated locally. Two high-effort Codex CLI reviews were run; confirmed findings were fixed and given regression coverage.Rollout dependency
Companion backend PR: https://github.com/SocketDev/depscan/pull/28901
Keep this PR in draft until the backend is deployed and the existing legacy pgx patch is regenerated through the existing package-reset/admin workflow. The strict production hosted canary currently fails with
redirect_golang_unsupported, because production has not published that patch's/v5hosted module. It must pass before this PR is ready to merge; do not replace it with an empty-consumer success.No production deployment or patch regeneration was performed. Existing checkouts created by older CLI releases without a checksum backup may still need
go mod download <module>@<version>after rollback; newly patched checkouts restore their saved checksums offline.Generated by Claude Code