Skip to content

CI: fix Windows nightly yarnrc path expectation (#1689) #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CI: fix Windows nightly yarnrc path expectation (#1689) #1710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e8e4c
Fix Windows nightly yarnrc test path expectation
claude Oct 24, 2026
50f5840
Correct Windows root-relative join comment
claude Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions crates/socket-patch-core/src/patch/redirect/yarnrc_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,16 +586,19 @@ fn global_folder_values_read_like_yarn() {
Vec::<PathBuf>::new()
);
// An escaped expression stays verbatim (`ini` reads `\\` as `\`
// first).
// first). On Windows the leading `\` makes it root-relative: it keeps
// the cwd's drive and replaces the rest, as `path.resolve` does
// (`/w` has no drive, so nothing of it is kept).
let escaped = if cfg!(windows) {
"\\${HOME}/x"
} else {
"/w/\\${HOME}/x"
};
for text in [
"global-folder=\\${HOME}/x\n",
"global-folder=\\\\${HOME}/x\n",
] {
assert_eq!(
npmrc(Host::new(), text),
paths(&["/w/\\${HOME}/x"]),
"{text:?}"
);
assert_eq!(npmrc(Host::new(), text), paths(&[escaped]), "{text:?}");
}
// `ini` ends an unquoted value at a comment and unquotes a quoted one.
assert_eq!(
Expand Down
Loading