Repository navigation
perf(start-plugin-core): avoid repeated work in Rsbuild compilation scans - #8799
mattcosta7 wants to merge 4 commits into
Conversation
Normalizing the client build scanned every chunk's modules twice, once for route split queries and once for hydration queries, calling the native identifier() each time. Read both from one scan with the same literal-key guards and first-value semantics. Replaying server function metadata at finishMake validated every module's buildInfo with zod, even though nearly all modules carry none. Validate only modules that have the field.
🦋 Changeset detectedLatest commit: b277e7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Skip validation when metadata is absent packages/start-plugin-core/src/rsbuild/start-compiler-host.ts, .changeset/rsbuild-cheaper-compilation-scans.md |
readServerFnBuildInfo checks for undefined metadata before schema validation. The changeset requests a patch release and describes this update. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Refactor
Possibly related issues
- TanStack/router issue 8810 — It tracks build-time speed work that includes skipping schema parsing for modules without server-function metadata.
Suggested labels: package: start-plugin-core
Suggested reviewers: schiller-manuel
Merge Risk: 
b277e
-
No actionable merge-blocking risk is identified in the supplied changes.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title clearly identifies an Rsbuild performance change. It is broad because the current summary mainly covers avoiding unnecessary server-function metadata validation, but it remains related to th… Description check The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, implementation, measurements, overlap with other pull requests, testing, AI assistanc… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title clearly identifies an Rsbuild performance change. It is broad because the current summary mainly covers avoiding unnecessary server-function metadata validation, but it remains related to the pull request objective.
Full details: Description check
-
Explanation
The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, implementation, measurements, overlap with other pull requests, testing, AI assistance, and changeset. One understanding-code checklist item remains unchecked, but the description is otherwise complete.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…-hydrate query rules Ports upstream #8799's normalization tests: literal query keys, first value, +/% decoding, lookalike keys, concatenateModules on and off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🎯 Changes
Two passes that run on every Rsbuild compilation did avoidable work.
Client build normalization scanned each chunk's modules twice, once for
tsr-splitand once fortss-hydrate, calling the nativeidentifier()each time. It now reads both in one scan. The literal-key guards stay separate, so encoded keys and first-value semantics are unchanged; new tests cover repeated, empty,+-encoded and percent-encoded keys, lookalike keys, and concatenation on and off.Server function metadata replay (
finishMake, stage -20) ranserverFnBuildInfoSchema.safeParseon every module'sbuildInfo, although almost no modules have the field. It now returns early when the field is absent, which was already the result.Normalization numbers are from the new
tests/rsbuild/normalized-client-build.bench.ts(real Rspack compilations, 8 and 128 routes, concatenation on and off), same fixture before and after. Client bundle output is unchanged.Overlap with open PRs
Both halves overlap older open PRs, and I'd rather those land:
readServerFnBuildInfoearly return. Prefer perf: reduce repeated Zod validation work #8305: it's older and covers Zod work beyond this one function. If it merges first, I'll drop thestart-compiler-host.tschange from this PR. If this merges first, perf: reduce repeated Zod validation work #8305's rebase drops its identical hunk.getChunkMetadataFromModulesin place of its two extractors.So this PR is the small, low-risk fallback if those stay stalled; happy to close it once they move.
Written with an AI coding assistant.
✅ Checklist
🚀 Release Impact
Summary by CodeRabbit